Skip to content

Move invocation of initialize above setting of attributes and validation #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2015

Conversation

TylerBrock
Copy link
Contributor

If initialize is used to initialize objects (provide defaults, etc) it should happen before the provided attributes are set on the object and validated, not after.

This attempts to resolve part of the second blocker in #73.

@codecov-io
Copy link

Current coverage is 85.22%

Merging #81 into master will increase coverage by +0.03% as of f2a68f9

@@            master     #81   diff @@
======================================
  Files           37      37       
  Stmts         2796    2796       
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit           2382    2383     +1
  Partial          0       0       
+ Missed         414     413     -1

Review entire Coverage Diff as of f2a68f9

Powered by Codecov. Updated on successful CI builds.

@TylerBrock TylerBrock changed the title Move invocation of initialize above setting of attributes Move invocation of initialize above setting of attributes and validation Nov 4, 2015
andrewimm added a commit that referenced this pull request Dec 21, 2015
Move invocation of initialize above setting of attributes and validation
@andrewimm andrewimm merged commit abe5a53 into parse-community:master Dec 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants