Skip to content

Support isDataAvailable #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2019
Merged

Support isDataAvailable #856

merged 2 commits into from
Jul 11, 2019

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Jul 10, 2019

Closes: #851

Checks if an object has been fetched from the server or not.

@dplewis dplewis requested a review from acinader July 10, 2019 22:00
Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a) this is amazing
b) package lock file is dirty

@codecov
Copy link

codecov bot commented Jul 11, 2019

Codecov Report

Merging #856 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #856      +/-   ##
==========================================
+ Coverage   92.07%   92.08%   +<.01%     
==========================================
  Files          54       54              
  Lines        4973     4976       +3     
  Branches     1109     1109              
==========================================
+ Hits         4579     4582       +3     
  Misses        394      394
Impacted Files Coverage Δ
src/ParseObject.js 90.1% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 174d108...19b8edf. Read the comment docs.

Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add isDataAvailable function to help determine if object is only pointer.
2 participants