Skip to content

Set Class Level Permission via Parse.Schema #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 16, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
90 changes: 90 additions & 0 deletions integration/test/ParseSchemaTest.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,28 @@ const assert = require('assert');
const clear = require('./clear');
const Parse = require('../../node');

const emptyCLPS = {
find: {},
count: {},
get: {},
create: {},
update: {},
delete: {},
addField: {},
protectedFields: {},
};

const defaultCLPS = {
find: { '*': true },
count: { '*': true },
get: { '*': true },
create: { '*': true },
update: { '*': true },
delete: { '*': true },
addField: { '*': true },
protectedFields: { '*': [] },
};

describe('Schema', () => {
beforeAll(() => {
Parse.initialize('integration');
Expand Down Expand Up @@ -82,6 +104,74 @@ describe('Schema', () => {
});
});

it('save class level permissions', async () => {
const clp = {
get: { requiresAuthentication: true },
find: {},
count: {},
create: { '*': true },
update: { requiresAuthentication: true },
delete: {},
addField: {},
protectedFields: {}
};
const testSchema = new Parse.Schema('SchemaTest');
testSchema.setCLP(clp);
const schema = await testSchema.save();
assert.deepEqual(schema.classLevelPermissions, clp);
});

it('update class level permissions', async () => {
const clp = {
get: { requiresAuthentication: true },
find: {},
count: {},
create: { '*': true },
update: { requiresAuthentication: true },
delete: {},
addField: {},
protectedFields: {}
};
const testSchema = new Parse.Schema('SchemaTest');
let schema = await testSchema.save();
assert.deepEqual(schema.classLevelPermissions, defaultCLPS);

testSchema.setCLP(1234);
schema = await testSchema.update();
assert.deepEqual(schema.classLevelPermissions, emptyCLPS);

testSchema.setCLP(clp);
schema = await testSchema.update();
assert.deepEqual(schema.classLevelPermissions, clp);

testSchema.setCLP({});
schema = await testSchema.update();
assert.deepEqual(schema.classLevelPermissions, emptyCLPS);
});

it('update class level permissions multiple', async () => {
const clp = {
get: { requiresAuthentication: true },
find: {},
count: {},
create: { '*': true },
update: { requiresAuthentication: true },
delete: {},
addField: {},
protectedFields: {}
};
const testSchema = new Parse.Schema('SchemaTest');
testSchema.setCLP(clp);
let schema = await testSchema.save();
assert.deepEqual(schema.classLevelPermissions, clp);

schema = await testSchema.update();
assert.deepEqual(schema.classLevelPermissions, clp);

schema = await testSchema.update();
assert.deepEqual(schema.classLevelPermissions, clp);
});

it('update', (done) => {
const testSchema = new Parse.Schema('SchemaTest');
testSchema.addString('name');
Expand Down
15 changes: 15 additions & 0 deletions src/ParseSchema.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ class ParseSchema {
className: string;
_fields: { [key: string]: mixed };
_indexes: { [key: string]: mixed };
_clp: { [key: string]: mixed };

/**
* @param {String} className Parse Class string.
Expand Down Expand Up @@ -97,6 +98,7 @@ class ParseSchema {
className: this.className,
fields: this._fields,
indexes: this._indexes,
classLevelPermissions: this._clp,
};

return controller.create(this.className, params);
Expand All @@ -116,6 +118,7 @@ class ParseSchema {
className: this.className,
fields: this._fields,
indexes: this._indexes,
classLevelPermissions: this._clp,
};

this._fields = {};
Expand Down Expand Up @@ -161,6 +164,18 @@ class ParseSchema {
}
}

/**
* Sets Class Level Permissions when creating / updating a Schema.
* EXERCISE CAUTION, running this may override CLP for this schema and cannot be reversed
*
* @param {Object} clp Class Level Permissions
* @return {Parse.Schema} Returns the schema, so you can chain this call.
*/
setCLP(clp: { [key: string]: mixed }) {
this._clp = clp;
return this;
}

/**
* Adding a Field to Create / Update a Schema
*
Expand Down
22 changes: 22 additions & 0 deletions src/__tests__/ParseSchema-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,28 @@ describe('ParseSchema', () => {
done();
});

it('can set schema class level permissions', (done) => {
const schema = new ParseSchema('SchemaTest');
expect(schema._clp).toBeUndefined();
schema.setCLP(undefined);
expect(schema._clp).toBeUndefined();
schema.setCLP({});
expect(schema._clp).toEqual({});
const clp = {
get: { requiresAuthentication: true },
find: {},
count: {},
create: { '*': true },
update: { requiresAuthentication: true },
delete: {},
addField: {},
protectedFields: {}
};
schema.setCLP(clp);
expect(schema._clp).toEqual(clp);
done();
});

it('cannot add field with null name', (done) => {
try {
const schema = new ParseSchema('SchemaTest');
Expand Down