Allowing to re-save installation if LDS is enabled #1125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hermanliang
force-pushed
the
resave-installation-lds-enabled
branch
from
dede394 to
d974128
Compare
hermanliang
force-pushed
the
resave-installation-lds-enabled
branch
from
3e3f1b1 to
9f38cdf
Compare
|
Should we add tests for that? Seems dangerous to add this behaviour without corresponding tests. |
|
@flovilmart related unit test is added |
hermanliang
force-pushed
the
resave-installation-lds-enabled
branch
from
f15e1d1 to
e9f48f4
Compare
hermanliang
force-pushed
the
resave-installation-lds-enabled
branch
from
e9f48f4 to
1ba958e
Compare
hermanliang
force-pushed
the
resave-installation-lds-enabled
branch
from
fff4613 to
792844e
Compare
hermanliang
force-pushed
the
resave-installation-lds-enabled
branch
from
29e516c to
a8132af
Compare
|
@flovilmart I think it's okay to merge now. Thanks! |
|
@flovilmart can you help me merge this PR, since I'm not permitted to merge in this repo. |
|
Sorry, didn't see your previous comment! |
|
No worries. Thanks! |
tkhoa87
added a commit
to notabasement/Parse-SDK-iOS-OSX
that referenced
this pull request
Jun 30, 2017
* ParsePlatform/master: ⚡️ Release 1.15.0 (parse-community#1153) ⚡ Release 1.14.5 (parse-community#1152) Add withinPolygon to Query (parse-community#1150) Use getter instead accessing instance variable (parse-community#1026) Makes PFEncoder and PFDecoder public for LiveQuery (parse-community#1149) Let the iOS SDK handle Delete ops when sent from the server (parse-community#928) Outputing offending bundle in assert message. (parse-community#1000) Update documentation links (parse-community#1102) Swift 3 (parse-community#1145) Allowing to re-save installation if LDS is enabled (parse-community#1125) Removed or replaced the broken links in the README (parse-community#1141) update pod spec homepage (parse-community#1135) Update podspec link Update links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
parse-community/Parse-SDK-Android#605: Re-save installation is allowed if LDS is enabled
Related PR
parse-community/Parse-SDK-Android#607: Re-save installation is allowed if LDS is enabled
parse-community/Parse-SDK-Android#611: Not allowing setObjectId() in ParseInstallation
In this PR
setObjectIdis not allowed inPFInstallationfor safety purpose.@rogerhu