Full Text Search Query #1196
Full Text Search Query #1196
Conversation
Parse/PFQuery.h
Outdated
|
|
||
| @return The same instance of `PFQuery` as the receiver. This allows method chaining. | ||
| */ | ||
| - (instancetype)whereKey:(NSString *)key fullText:(NSString *)text; |
There was a problem hiding this comment.
Can we call it matchesText instead of fullText?
|
Awesome! Let’s make a plan for the 3.0 release so we can release everything at once :) |
|
Works for me |
|
Looks like this is just about good, and the requested changes have been added some time ago now...I'll assign myself and give this a better look in a bit. |
There was a problem hiding this comment.
Alright, was just comparing this against what you submitted over for #333 and this looks good 👍 .
@flovilmart removed your old review but if you have any additional thoughts let me know. Looks like we're ready to merge this in though.
|
Hi @montymxb as the changes have been approved can we get this one merged in? |
|
@johnantoni Yes we can! Seems we didn't follow up after approval... |
Ref: parse-community/parse-server#3904
Closes: #1167