Skip to content

SSL Certificate Pinning delegate #1598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 43 commits into from
Closed

Conversation

gytiskv
Copy link

@gytiskv gytiskv commented Jan 25, 2021

This adds a PFUrlSessionChallengeDelegate to Parse Configuration.

Note:
Docs and description will be added soon.

drdaz and others added 30 commits December 19, 2019 14:58
Adds usage information for convert_images.rb script
# Conflicts:
#	Parse/Parse.xcodeproj/xcshareddata/xcschemes/Parse-iOS-Dynamic.xcscheme
#	Parse/Parse.xcodeproj/xcshareddata/xcschemes/Parse-iOS.xcscheme
#	Parse/Parse.xcodeproj/xcshareddata/xcschemes/Parse-macOS.xcscheme
#	Parse/Parse.xcodeproj/xcshareddata/xcschemes/Parse-tvOS-Dynamic.xcscheme
#	Parse/Parse.xcodeproj/xcshareddata/xcschemes/Parse-tvOS.xcscheme
#	Parse/Parse.xcodeproj/xcshareddata/xcschemes/Parse-watchOS-Dynamic.xcscheme
#	Parse/Parse.xcodeproj/xcshareddata/xcschemes/Parse-watchOS.xcscheme
#	ParseFacebookUtils/ParseFacebookUtils.xcodeproj/xcshareddata/xcschemes/ParseFacebookUtilsV4-iOS-Dynamic.xcscheme
#	ParseFacebookUtils/ParseFacebookUtils.xcodeproj/xcshareddata/xcschemes/ParseFacebookUtilsV4-iOS.xcscheme
#	ParseFacebookUtils/ParseFacebookUtils.xcodeproj/xcshareddata/xcschemes/ParseFacebookUtilsV4-tvOS-Dynamic.xcscheme
#	ParseFacebookUtils/ParseFacebookUtils.xcodeproj/xcshareddata/xcschemes/ParseFacebookUtilsV4-tvOS.xcscheme
#	ParseTwitterUtils/ParseTwitterUtils.xcodeproj/xcshareddata/xcschemes/ParseTwitterUtils-iOS-Dynamic.xcscheme
#	ParseTwitterUtils/ParseTwitterUtils.xcodeproj/xcshareddata/xcschemes/ParseTwitterUtils-iOS.xcscheme
#	ParseUI/Generated/PFResources.h
#	ParseUI/ParseUI.xcodeproj/project.pbxproj
#	ParseUI/ParseUI.xcodeproj/xcshareddata/xcschemes/ParseUI-Dynamic.xcscheme
#	ParseUI/ParseUI.xcodeproj/xcshareddata/xcschemes/ParseUI.xcscheme
#	ParseUI/ParseUI.xcodeproj/xcshareddata/xcschemes/ParseUIDemo-Swift.xcscheme
#	ParseUI/ParseUI.xcodeproj/xcshareddata/xcschemes/ParseUIDemo.xcscheme
It was the cause of the stack of warnings that came with every build.
@magneticrob
Copy link

Hey guys, is there anything I can do to help get this PR merged? Quite eager to implement certificate pinning in my iOS app.

@gytiskv gytiskv changed the title SSL Pinning delegate method SSL Certificate Pinning delegate Feb 5, 2021
@TomWFox
Copy link
Contributor

TomWFox commented Feb 10, 2021

@magneticrob thanks for chiming in, really the main block right now is a review from a maintainer. I can't do that at the moment.

If you could review this yourself and/or test it out in your own app that would be helpful but I can't say it will be merged immediately after that.

In the meantime though, you could use @gytiskv's fork in your app.

@drdaz
Copy link
Member

drdaz commented May 27, 2021

Thanks for submitting this.

Is there any way we can get your changes against current master? There's some odd stuff going on with version numbers, and I'm not sure why; I suspect it's to do with the basing of your branch. Certainly, we don't want to be downgrading Swift version and a bunch of dependencies.

There don't appear to be automated tests for the new functionality. We’ll need those.

I haven't opened the project in Xcode, but looking at the changes there appears to be a new tester app? What’s going on there?

@stale
Copy link

stale bot commented Jul 13, 2021

This issue has been automatically marked as stale because it has not had recent activity. If you believe it should stay open, please let us know! As always, we encourage contributions, check out the Contributing Guide

@stale stale bot added the Stale label Jul 13, 2021
@stale stale bot closed this Jul 21, 2021
@cbaker6 cbaker6 reopened this Oct 11, 2021
@stale stale bot removed the Stale label Oct 11, 2021
@mtrezza
Copy link
Member

mtrezza commented Oct 24, 2023

Closing as it seems stale and requires an extensive rebase on the master branch.

@mtrezza mtrezza closed this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants