-
-
Notifications
You must be signed in to change notification settings - Fork 69
ci: fix codecov for iOS #262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request!
|
Codecov Report
@@ Coverage Diff @@
## main #262 +/- ##
==========================================
- Coverage 85.50% 82.30% -3.21%
==========================================
Files 101 99 -2
Lines 10467 10512 +45
==========================================
- Hits 8950 8652 -298
- Misses 1517 1860 +343
Continue to review full report at Codecov.
|
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
Codecov for iOS is currently the only not being calculated.
Github Actions recently updated SwiftLint which allows
id
by default. Make change to prevent errors.Related issue: #N/A
Approach
TODOs before merging
id
needing to be ignored. Developers should upgrade their SwiftLint,brew upgrade swiftlint
ParseOperation