Skip to content

ci: fix codecov for iOS #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 20, 2021
Merged

ci: fix codecov for iOS #262

merged 13 commits into from
Oct 20, 2021

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Oct 20, 2021

New Pull Request Checklist

Issue Description

Codecov for iOS is currently the only not being calculated.

Github Actions recently updated SwiftLint which allows id by default. Make change to prevent errors.

Related issue: #N/A

Approach

TODOs before merging

  • Fix codecov for iOS
  • Git Actions has updated SwiftLint which removed id needing to be ignored. Developers should upgrade their SwiftLint, brew upgrade swiftlint
  • Improve coverage of ParseOperation

@parse-github-assistant
Copy link

parse-github-assistant bot commented Oct 20, 2021

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #262 (aef5647) into main (0e646a2) will decrease coverage by 3.20%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #262      +/-   ##
==========================================
- Coverage   85.50%   82.30%   -3.21%     
==========================================
  Files         101       99       -2     
  Lines       10467    10512      +45     
==========================================
- Hits         8950     8652     -298     
- Misses       1517     1860     +343     
Impacted Files Coverage Δ
...thentication/3rd Party/ParseApple/ParseApple.swift 82.50% <ø> (-3.75%) ⬇️
...cation/3rd Party/ParseFacebook/ParseFacebook.swift 100.00% <ø> (ø)
...tication/3rd Party/ParseLDAP/ParseLDAP+async.swift 100.00% <ø> (ø)
...cation/3rd Party/ParseLDAP/ParseLDAP+combine.swift 100.00% <ø> (ø)
...Authentication/3rd Party/ParseLDAP/ParseLDAP.swift 100.00% <ø> (ø)
...tication/3rd Party/ParseTwitter/ParseTwitter.swift 100.00% <ø> (ø)
...Swift/Authentication/Internal/ParseAnonymous.swift 100.00% <ø> (ø)
Sources/ParseSwift/Objects/ParseObject.swift 74.57% <0.00%> (-3.56%) ⬇️
Sources/ParseSwift/Types/ParseFile.swift 80.38% <ø> (-7.72%) ⬇️
Sources/ParseSwift/Coding/AnyCodable.swift 22.95% <0.00%> (-32.79%) ⬇️
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e646a2...aef5647. Read the comment docs.

@cbaker6 cbaker6 merged commit 9cea2bf into main Oct 20, 2021
@cbaker6 cbaker6 deleted the updateCodecov branch October 20, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant