Skip to content

Fix callbackqueue bug #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 8, 2020
Merged

Fix callbackqueue bug #27

merged 7 commits into from
Nov 8, 2020

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Nov 6, 2020

There's a bug where the specified callback queue was being used in the incorrect place causing crashing in apps.

This most likely fixes the random crash from the tests that was occurring. This PR specifically addresses the following:

  • Fixes callback queue (mentioned above)
  • Adds tvOS testing to CI (most of the added files are due to adding TestHostTV app and it's related files)
  • Fixes scheme in .spi.yml so SwiftPackageIndex ignores watchOS tests

@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #27 (3441531) into main (db7a388) will decrease coverage by 0.00%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
- Coverage   71.48%   71.47%   -0.01%     
==========================================
  Files          30       30              
  Lines        1785     1788       +3     
==========================================
+ Hits         1276     1278       +2     
- Misses        509      510       +1     
Impacted Files Coverage Δ
Sources/ParseSwift/API/API+Commands.swift 62.17% <88.88%> (+0.67%) ⬆️
Sources/ParseSwift/API/URLSession+extensions.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db7a388...3441531. Read the comment docs.

@cbaker6
Copy link
Contributor Author

cbaker6 commented Nov 7, 2020

@pranjalsatija can you review this?

@cbaker6
Copy link
Contributor Author

cbaker6 commented Nov 8, 2020

@TomWFox can you replace "xcode-build-tvos" with "xcode-test-tvos" in the branch protections? I've added testing to tvOS.

@cbaker6 cbaker6 merged commit 7015af2 into main Nov 8, 2020
@cbaker6 cbaker6 deleted the minor branch November 8, 2020 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants