Skip to content

fix: improve codable's #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2022
Merged

fix: improve codable's #352

merged 1 commit into from
Apr 7, 2022

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Apr 7, 2022

New Pull Request Checklist

Issue Description

Improve the ability of the internal AnyCodable to encode Encodable.

Related issue: #n/a

Approach

Add more test cases.

TODOs before merging

  • Add tests

@parse-github-assistant
Copy link

parse-github-assistant bot commented Apr 7, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #352 (cf8ff55) into main (8b90507) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #352      +/-   ##
==========================================
+ Coverage   87.31%   87.35%   +0.04%     
==========================================
  Files         114      114              
  Lines       12207    12209       +2     
==========================================
+ Hits        10658    10665       +7     
+ Misses       1549     1544       -5     
Impacted Files Coverage Δ
Sources/ParseSwift/Coding/AnyDecodable.swift 27.47% <ø> (ø)
Sources/ParseSwift/Coding/AnyEncodable.swift 52.29% <100.00%> (+2.88%) ⬆️
Sources/ParseSwift/Objects/ParseObject.swift 84.88% <0.00%> (-0.46%) ⬇️
Sources/ParseSwift/LiveQuery/ParseLiveQuery.swift 73.63% <0.00%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b90507...cf8ff55. Read the comment docs.

@cbaker6 cbaker6 merged commit eb755d2 into parse-community:main Apr 7, 2022
@cbaker6 cbaker6 deleted the improveEncoding branch April 7, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant