-
-
Notifications
You must be signed in to change notification settings - Fork 132
Conversation
Note that Travis seems to be having some issues with Xcode builds, but I don't see the issue listed on travis. You may have to rerun the travis build if it fails to start |
Higher versions of Starscream will cause breaking change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually... the changelog needs an entry
Co-authored-by: Tom Fox <[email protected]>
@TomWFox do you if the COCOAPODS_TRUNK_TOKEN is set? Travis us giving this “ [!] You need to run |
It is set, it has probably just expired - they do that periodically |
Fairly sure the deployment is broken anyway because it work for the last release either |
I tried a few different things in travis, but couldn't get it to go. I agree that the deployment seems broken. I add this branch to push the pod manually for 2.7.3, https://github.com/parse-community/ParseLiveQuery-iOS-OSX/tree/2.7.3-pod |
I found the problem... During PR's to the master branch travis shows the following environment vars setup in the travis build log:
I think the In the
|
I think the |
Sorry for the lack of response here, I've been having all sorts of issues with my shell since updating to Big Sur 🤦 @drdaz Can you get a new trunk token and put it in travis? |
I'll see if I can figure that out later today 😃 |
I've updated the Cocoapods token in Travis and made it 'Available to all branches'. |
Thanks! |
I was able to deploy 2.7.3 and 2.8.0 via Travis by re-running the respective builds. The good thing about Travis is it can rerun the exact same build while pulling the latest env vars. We shouldn’t have an issue pushing via tags and Travis as long as the token doesn’t expire. Also, the docs are deploying again via Travis and jazzy. Only thing is, the code in this repo is currently undocumented. I made the web link align with the iOS and Swift repos, http://parseplatform.org/ParseLiveQuery-iOS-OSX/api/ |
Awesome. The token expires after some period (a couple months roughly) if not used which is likely on this repo. I believe all that is needed is to run |
I’ve seen cron in Travis, but I’ve never tried it. I wonder if setting the pod token to the same value as the iOS SDK (and eventually the Parse-Swift SDK) will fix the expiration problem since at least 1 of these should release within a 2 month period? |
Thats definitely a good idea. I think it would still be reasonably conceivable for the token to expire but with the same token in each we could have one Cron job as an insurance. |
This PR should probably be a release.