Skip to content
This repository was archived by the owner on Jun 13, 2023. It is now read-only.

Add watchOS and tvOS support #235

Merged
merged 25 commits into from
Nov 16, 2020
Merged

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Nov 15, 2020

  • Add watchOS and tvOS support
  • Add cache to travis and circle for faster builds
  • Move Carthage build to last in circle since it's the slowest and more important to see if iOS, macOS, and demo builds
  • Update project versions to prepare for release, updated the versions to 2.7.3
  • Update jazzy docs to newer version

This PR should probably be a release.

@cbaker6 cbaker6 marked this pull request as draft November 15, 2020 14:49
@cbaker6 cbaker6 closed this Nov 15, 2020
@cbaker6 cbaker6 reopened this Nov 15, 2020
@cbaker6 cbaker6 closed this Nov 15, 2020
@cbaker6 cbaker6 reopened this Nov 15, 2020
@cbaker6 cbaker6 marked this pull request as ready for review November 15, 2020 19:12
@cbaker6 cbaker6 requested a review from drdaz November 15, 2020 19:12
@cbaker6
Copy link
Contributor Author

cbaker6 commented Nov 15, 2020

Note that Travis seems to be having some issues with Xcode builds, but I don't see the issue listed on travis. You may have to rerun the travis build if it fails to start

@cbaker6 cbaker6 mentioned this pull request Nov 15, 2020
3 tasks
@cbaker6 cbaker6 requested a review from a team November 15, 2020 22:51
@cbaker6 cbaker6 changed the title Add watchOS support to cocoapods Add watchOS support Nov 16, 2020
@cbaker6 cbaker6 changed the title Add watchOS support Add watchOS and tvOS support Nov 16, 2020
Copy link
Member

@drdaz drdaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

Copy link
Member

@drdaz drdaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually... the changelog needs an entry

Co-authored-by: Tom Fox <[email protected]>
@cbaker6 cbaker6 merged commit db0458f into parse-community:master Nov 16, 2020
@cbaker6 cbaker6 deleted the watchOS branch November 16, 2020 19:09
@cbaker6
Copy link
Contributor Author

cbaker6 commented Nov 16, 2020

@TomWFox @drdaz can one of you push the pods? It looks like it failed to deploy and didn't give much info about the failure.

@cbaker6
Copy link
Contributor Author

cbaker6 commented Nov 16, 2020

@TomWFox do you if the COCOAPODS_TRUNK_TOKEN is set? Travis us giving this “ [!] You need to run pod trunk register to register a session first.”

@TomWFox
Copy link
Contributor

TomWFox commented Nov 16, 2020

It is set, it has probably just expired - they do that periodically

@TomWFox
Copy link
Contributor

TomWFox commented Nov 16, 2020

Fairly sure the deployment is broken anyway because it work for the last release either

@cbaker6
Copy link
Contributor Author

cbaker6 commented Nov 17, 2020

I tried a few different things in travis, but couldn't get it to go. I agree that the deployment seems broken.

I add this branch to push the pod manually for 2.7.3, https://github.com/parse-community/ParseLiveQuery-iOS-OSX/tree/2.7.3-pod

@cbaker6
Copy link
Contributor Author

cbaker6 commented Nov 17, 2020

I found the problem...

During PR's to the master branch travis shows the following environment vars setup in the travis build log:
https://travis-ci.com/github/parse-community/ParseLiveQuery-iOS-OSX/jobs/441210418#L121

Setting environment variables from repository settings
120$ export GITHUB_TOKEN=[secure]
121$ export COCOAPODS_TRUNK_TOKEN=[secure]

I think the In the COCOAPODS_TRUNK_TOKEN isn't enabled for tags as it doesn't show in the logs anymore, the environment variable is missing. @TomWFox can you try to completely delete it and add it back enabling it for tags?
https://travis-ci.com/github/parse-community/ParseLiveQuery-iOS-OSX/jobs/441073847#L134

Setting environment variables from repository settings
134$ export GITHUB_TOKEN=[secure]

@cbaker6
Copy link
Contributor Author

cbaker6 commented Nov 17, 2020

I think the Only available to the master branch is what's blocking it from tags. Setting it to Available to all branches should fix it

@TomWFox
Copy link
Contributor

TomWFox commented Nov 17, 2020

Sorry for the lack of response here, I've been having all sorts of issues with my shell since updating to Big Sur 🤦

@drdaz Can you get a new trunk token and put it in travis?

@drdaz
Copy link
Member

drdaz commented Nov 18, 2020

I'll see if I can figure that out later today 😃

@drdaz
Copy link
Member

drdaz commented Nov 18, 2020

I've updated the Cocoapods token in Travis and made it 'Available to all branches'.

@TomWFox
Copy link
Contributor

TomWFox commented Nov 18, 2020

Thanks!

@cbaker6
Copy link
Contributor Author

cbaker6 commented Nov 18, 2020

I was able to deploy 2.7.3 and 2.8.0 via Travis by re-running the respective builds. The good thing about Travis is it can rerun the exact same build while pulling the latest env vars. We shouldn’t have an issue pushing via tags and Travis as long as the token doesn’t expire.

Also, the docs are deploying again via Travis and jazzy. Only thing is, the code in this repo is currently undocumented. I made the web link align with the iOS and Swift repos, http://parseplatform.org/ParseLiveQuery-iOS-OSX/api/

@TomWFox
Copy link
Contributor

TomWFox commented Nov 18, 2020

Awesome. The token expires after some period (a couple months roughly) if not used which is likely on this repo. I believe all that is needed is to run pod trunk me periodically which could be done with a Cron job.

@cbaker6
Copy link
Contributor Author

cbaker6 commented Nov 18, 2020

I’ve seen cron in Travis, but I’ve never tried it. I wonder if setting the pod token to the same value as the iOS SDK (and eventually the Parse-Swift SDK) will fix the expiration problem since at least 1 of these should release within a 2 month period?

@TomWFox
Copy link
Contributor

TomWFox commented Nov 18, 2020

Thats definitely a good idea. I think it would still be reasonably conceivable for the token to expire but with the same token in each we could have one Cron job as an insurance.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants