This repository was archived by the owner on Jan 26, 2021. It is now read-only.
Fixing the Logout/currentUser race condition. #179
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code change fixes a race condition in the overriden Parse.User.logOut() method.
The
logOut()
method is supposed to reset the current user tonull
but the code path is not waiting for theoldLogOut()
promise result to update thecurrentUser
state in the local subscriptions module (LocalSubscriptions.js
) which causes theLocalSubscription.currentUser.update()
method to call thesetCurrentUser(...)
with the stale user object.Example
The JS code snippet above is supposed to log "null" as the value of the user parameter, but it's logging the old stale user object all the time.