Skip to content
This repository was archived by the owner on Jan 26, 2021. It is now read-only.

Updated Subscription Documentation #26

Closed
wants to merge 3 commits into from
Closed

Updated Subscription Documentation #26

wants to merge 3 commits into from

Conversation

agnosticdev
Copy link

Added an example of relational queries in the subscription documentation.

The added documentation for relational queries came from a request from @paramaggarwal.
#20
@paramaggarwal
Copy link

Excellent @agnosticdev, thanks!

@agnosticdev
Copy link
Author

No problem!

@andrewimm
Copy link
Contributor

Other than providing clarity, why does it need to be in a separate method. I worry it's confusing to break it out of the observe body for an example, and I'm also not sure why it's necessary to demonstrate a special case for relations.

It might be better to discuss "complex queries" after the first example. Something along the lines of "for queries that cannot be constructed on one line of code, it's recommended you build them within the observe() method before constructing and returning your map of observations," but more fleshed out.

Updated the subscription documentation to help illustrate defining complex queries in the observe method.
@ghost
Copy link

ghost commented Aug 4, 2015

Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

@paramaggarwal
Copy link

Agree with @andrewimm. I didn't get it before, but I now understand that observe simply accepts a bunch of promises. @agnosticdev's example can be added as part of the main doc itself without a need for making a separate section.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants