Skip to content

Fix Swift sample for SignUpViewController fields #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

richard4339
Copy link
Contributor

The swift example was actually the Objective C sample. Modified it to be an array and changed the wording below to match the wording in the LogInViewController sample above.

The swift example was actually the Objective C sample. Modified it to be an array and changed the wording below to match the wording in the LogInViewController sample above.
@ghost ghost added the CLA Signed label Aug 21, 2016
@hramos
Copy link
Contributor

hramos commented Aug 22, 2016

The code update looks good, but the wording now only matches the Swift example. Think there's any wording we could use here that works for both?

@richard4339
Copy link
Contributor Author

I was honestly thinking the same thing. Before I address that I'll ask
another question first: I assume it's JavaScript swapping the sample code
from objective c to swift; there isn't anything in place that will swap the
wording in the documentation anywhere is there? I haven't seen anything
like that, but I haven't read the entire thing in depth (nor have I found
the JavaScript that swaps it when viewing the source code).

If not, I'll just reword both to be an "if objective c ... if swift ..."
type sentence.

On Monday, August 22, 2016, Héctor Ramos [email protected] wrote:

The code update looks good, but the wording now only matches the Swift
example. Think there's any wording we could use here that works for both?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#368 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGJxCUQhKUT4o0PfuDoBvqO03h25l8sks5qiaEUgaJpZM4JpT1L
.

Richard
[email protected]

@hramos
Copy link
Contributor

hramos commented Aug 22, 2016

The code swapping is done in JavaScript, in main.js. It only toggles the code blocks, so the attached text should work for both. Perhaps this is a case where the code speaks for itself, and we don't need to point out Swift uses an array? The copy can just mention that one should pass the specific flags the login view controller should use.

@TomWFox
Copy link
Contributor

TomWFox commented Mar 9, 2019

It’s unfortunate that this has been dormant for so long. Would you either add two separate descriptions for swift and objective-c or remove the description entirely.

Alternatively you could add it as a comment in the code snippets.

If you make these changes (and resolve the conflict) I will happily merge this or pr the change myself.

@TomWFox TomWFox self-assigned this Mar 9, 2019
@TomWFox
Copy link
Contributor

TomWFox commented Mar 12, 2019

I'm closing this now as I'm working on a PR to fix this an other syntax issues with the Parse UI docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants