Update Init for Facebook #389
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating for swift 3
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
hramos
suggested changes
Nov 28, 2016
en/ios/users.mdown
Outdated
| Parse.setApplicationId("parseAppId", clientKey:"parseClientKey") | ||
| PFFacebookUtils.initializeFacebookWithApplicationLaunchOptions(launchOptions) | ||
| // AppDelegate.swift (Swift 3) | ||
| func application(application: UIApplication, didFinishLaunchingWithOptions launchOptions: [NSObject: AnyObject]?) -> Bool { |
There was a problem hiding this comment.
Is > necessary here? It should render fine within the code block, and it looks like you didn't need to use this encoding later in the same file.
for some reason > was encoded to >
|
I'm sorry that this has been over looked. Would you be able to update this code for swift 4.2 (+ the latest version of the Parse iOS SDK) and then I will take another look? Also would you be able to remove the vertical parameter alignment as it doesn't appear well on the docs: |
|
I'm closing this now as I have started a new pull request (#594) that brings in these changes (those of which are still needed). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating for swift 3