fix: Clicking reload button in info panel may display fetched data in incorrect panel

[mtrezza]

Pull Request

• Report security issues confidentially.
• Any contribution is under this license.

Issue

Clicking reload button in info panel may populate incorrect panel with fetched data.

Summary by CodeRabbit

• Bug Fixes
  • Improved concurrent data fetch request handling to prevent stale data from being displayed.
  • Added automatic cancellation of outdated requests before initiating new ones.
  • Enhanced tracking mechanism to ensure data integrity when multiple requests are in flight.

[parse-github-assistant]

🚀 Thanks for opening this pull request!

[parseplatformorg]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[coderabbitai]

📝 Walkthrough

Walkthrough

Refactors info panel request management in Browser.react.js from a single query tracker to a per-objectId map, implementing cancellation logic and adding lastFetchedObjectId state for staleness detection. Propagates lastFetchedObjectId to DataBrowser to update how multiPanelData entries are keyed.

Changes

Cohort / File(s)	Summary
Info Panel Request Management src/dashboard/Data/Browser/Browser.react.js	Replaces currentInfoPanelQuery with infoPanelQueries map for per-object request tracking; adds lastFetchedObjectId state field and propagates it via props to DataBrowser; implements per-object request cancellation before initiating new requests and cleanup after completion.
Multi-Panel Data Keying src/dashboard/Data/Browser/DataBrowser.react.js	Updates multiPanelData entry keying to use lastFetchedObjectId (from props) instead of selectedObjectId (from state), changing how AggregationPanelData updates map to multi-panel storage.

Sequence Diagram

sequenceDiagram
    participant User as User
    participant Browser as Browser.react.js
    participant DB as DataBrowser.react.js
    participant CloudFn as Cloud Function

    User->>Browser: Select Object A
    Browser->>Browser: Check infoPanelQueries[A]
    Note over Browser: Cancel existing request if present
    Browser->>CloudFn: Initiate info panel request (objectId: A)
    Browser->>Browser: Store promise in infoPanelQueries[A]

    User->>Browser: Select Object B (before A completes)
    Browser->>Browser: Check infoPanelQueries[B]
    Browser->>CloudFn: Initiate info panel request (objectId: B)
    Browser->>Browser: Cancel infoPanelQueries[A]
    Browser->>Browser: Store promise in infoPanelQueries[B]

    CloudFn-->>Browser: Return response for B
    Browser->>Browser: Set lastFetchedObjectId = B
    Browser->>Browser: Verify promise matches infoPanelQueries[B]
    Browser->>DB: Pass lastFetchedObjectId=B via props
    Browser->>Browser: Delete infoPanelQueries[B]

    DB->>DB: Update multiPanelData[B] with AggregationPanelData
    Note over DB: Keyed by lastFetchedObjectId instead of selectedObjectId

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• feat: Add displaying multiple info panels and batch navigation #3020: Directly affected by changes to how multiPanelData is keyed, as this PR now uses lastFetchedObjectId instead of selectedObjectId for data mapping.
• fix: Race condition on info panel request shows info panel data not corresponding to selected cell #2909: Introduced the original currentInfoPanelQuery singleton approach that this PR generalizes to a per-objectId infoPanelQueries map.
• fix: Info panel covers whole sidebar if fewer objects than panels in multi-panel scenario #3042: Modifies DataBrowser.react.js panel-rendering logic around object ID usage, potentially touching overlapping code paths related to panel state updates.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is incomplete. While the Issue section is filled out, the Approach section is missing (should describe the implementation strategy), and the Tasks section is incomplete (no checkboxes addressed).	Add an Approach section explaining how the fix works (e.g., per-objectId request tracking and lastFetchedObjectId guard), and address relevant tasks like testing and documentation updates.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main fix: preventing incorrect panel population when reloading info panels, which aligns with the code changes that track lastFetchedObjectId to guard against stale responses.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments

src/dashboard/Data/Browser/Browser.react.js (2)

385-386: Static analysis: forEach callback should not return a value.

The arrow function implicitly returns the result of q.cancel?.(). Use braces to suppress the return.

Proposed fix

-    Object.values(this.infoPanelQueries).forEach(q => q.cancel?.());
+    Object.values(this.infoPanelQueries).forEach(q => { q.cancel?.(); });

---

447-504: Per-objectId cancellation and staleness guard look correct.

The flow properly cancels any in-flight request for the same objectId before issuing a new one, guards against stale responses by comparing the stored promise reference, and cleans up in finally. This directly addresses the bug described in the PR.

One minor note: lastFetchedObjectId is not initialized in the constructor's this.state (lines 141–208). While it defaults to undefined and the consumer checks truthiness, explicitly initializing it (e.g., lastFetchedObjectId: undefined) improves readability and makes the state shape self-documenting.

Optional: initialize lastFetchedObjectId in state

Add to the state initialization block around line 197:

       errorAggregatedData: {},
+      lastFetchedObjectId: undefined,
       classFilters: {}, // Map of className -> filters array

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[parseplatformorg]

🎉 This change has been released in version 8.5.0-alpha.3

[parseplatformorg]

🎉 This change has been released in version 8.5.0