Skip to content

fix: Clicking reload button in info panel may display fetched data in incorrect panel #3189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtrezza merged 1 commit into from
Feb 7, 2026
Merged

fix: Clicking reload button in info panel may display fetched data in incorrect panel #3189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions src/dashboard/Data/Browser/Browser.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,8 +289,8 @@ class Browser extends DashboardView {
this.handleAddToArrayConfig = this.handleAddToArrayConfig.bind(this);
this.handleConfirmAddToConfig = this.handleConfirmAddToConfig.bind(this);

// Handle for the ongoing info panel cloud function request
this.currentInfoPanelQuery = null;
// Map of objectId -> promise for ongoing info panel cloud function requests
this.infoPanelQueries = {};

this.dataBrowserRef = React.createRef();

Expand Down Expand Up @@ -382,10 +382,8 @@ class Browser extends DashboardView {
if (this.currentQuery) {
this.currentQuery.cancel();
}
if (this.currentInfoPanelQuery) {
this.currentInfoPanelQuery.cancel?.();
this.currentInfoPanelQuery = null;
}
Object.values(this.infoPanelQueries).forEach(q => q.cancel?.());
this.infoPanelQueries = {};
this.removeLocation();
window.removeEventListener('mouseup', this.onMouseUpRowCheckBox);
}
Expand Down Expand Up @@ -447,9 +445,10 @@ class Browser extends DashboardView {
}

fetchAggregationPanelData(objectId, className, appId) {
if (this.currentInfoPanelQuery) {
this.currentInfoPanelQuery.cancel?.();
this.currentInfoPanelQuery = null;
// Cancel any existing request for this specific objectId
if (this.infoPanelQueries[objectId]) {
this.infoPanelQueries[objectId].cancel?.();
delete this.infoPanelQueries[objectId];
}

this.setState({
Expand All @@ -472,14 +471,14 @@ class Browser extends DashboardView {

const promise = Parse.Cloud.run(cloudCodeFunction, params, options);
promise.cancel = () => requestTask?.abort();
this.currentInfoPanelQuery = promise;
this.infoPanelQueries[objectId] = promise;
promise.then(
result => {
if (this.currentInfoPanelQuery !== promise) {
if (this.infoPanelQueries[objectId] !== promise) {
return;
}
if (result && result.panel && result.panel && result.panel.segments) {
this.setState({ AggregationPanelData: result, isLoadingInfoPanel: false });
this.setState({ AggregationPanelData: result, isLoadingInfoPanel: false, lastFetchedObjectId: objectId });
} else {
this.setState({
isLoadingInfoPanel: false,
Expand All @@ -489,7 +488,7 @@ class Browser extends DashboardView {
}
},
error => {
if (this.currentInfoPanelQuery !== promise) {
if (this.infoPanelQueries[objectId] !== promise) {
return;
}
this.setState({
Expand All @@ -499,8 +498,8 @@ class Browser extends DashboardView {
this.showNote(this.state.errorAggregatedData, true);
}
).finally(() => {
if (this.currentInfoPanelQuery === promise) {
this.currentInfoPanelQuery = null;
if (this.infoPanelQueries[objectId] === promise) {
delete this.infoPanelQueries[objectId];
}
});
}
Expand Down Expand Up @@ -2870,6 +2869,7 @@ class Browser extends DashboardView {
setLoadingInfoPanel={this.setLoadingInfoPanel}
AggregationPanelData={this.state.AggregationPanelData}
setAggregationPanelData={this.setAggregationPanelData}
lastFetchedObjectId={this.state.lastFetchedObjectId}
setErrorAggregatedData={this.setErrorAggregatedData}
errorAggregatedData={this.state.errorAggregatedData}
appName={this.props.params.appId}
Expand Down
4 changes: 2 additions & 2 deletions src/dashboard/Data/Browser/DataBrowser.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,13 +561,13 @@ export default class DataBrowser extends React.Component {
// Store the fetched panel data in multiPanelData when it changes
if (
this.props.AggregationPanelData !== prevProps.AggregationPanelData &&
this.state.selectedObjectId &&
this.props.lastFetchedObjectId &&
Object.keys(this.props.AggregationPanelData).length > 0
) {
this.setState(prev => ({
multiPanelData: {
...prev.multiPanelData,
[this.state.selectedObjectId]: this.props.AggregationPanelData
[this.props.lastFetchedObjectId]: this.props.AggregationPanelData
}
}));
}
Expand Down
Loading