Upgrade react-router to v2 #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <Redirect from='/' to='/apps' /> | ||
| <Route path='/' component={App}> | ||
| <Route path='apps' component={AppsIndexPage} /> | ||
| return ( |
There was a problem hiding this comment.
seems that you have an indentation problem, please revert the file
|
By analyzing the blame information on this pull request, we identified @drew-gross to be a potential reviewer. |
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
|
@durunvo updated the pull request. |
jsdevjournal
changed the title
added 5 commits
March 8, 2016 21:19
… IDE indent system)
…ed router as context - Change AppsMenu.react from stateless to React.Component to get contextTypes
|
@durunvo updated the pull request. |
|
@durunvo updated the pull request. |
jsdevjournal
changed the title
|
@flovilmart All fixed |
|
Sweet, it all seems to work! Thanks for the help! |
|
@drew-gross actually I leave some syntax bug on this commit. Will submit new PR |
|
Whoops, sorry. I assumed it was done because you removed the WIP tag, and I checked out your branch and clicked around and it did seem to work. |
|
@drew-gross The bug is in PushNew.react.js |
|
new PR #116 |
|
Cool, good thing that page isn't visible to anyone currently. |
douglasmuraoka
pushed a commit
that referenced
this pull request
Nov 29, 2019
…tton style: Change API Reference button to Get Started
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.