Skip to content

Update getPath on Cloud Code #1613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 117 commits into from
Closed

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Nov 1, 2020

Hi all,

This PR is in relation to a PR I have made on the Parse Server repo that allows cloud files to be viewed in the dashboard.

Cheers

@ghost
Copy link

ghost commented Nov 2, 2020

Danger run resulted in 1 warning; to find out more, see the checks page.

Generated by 🚫 dangerJS

snyk-bot and others added 17 commits November 4, 2020 21:13
Snyk has created this PR to upgrade:
  - react from 16.13.1 to 16.14.0.
    See this package in npm: https://www.npmjs.com/package/react
  - react-dom from 16.13.1 to 16.14.0.
    See this package in npm: https://www.npmjs.com/package/react-dom

See this project in Snyk:
https://app.snyk.io/org/acinader/project/953c8e1a-a9ef-4134-afbe-43474913abbb?utm_source=github&utm_medium=upgrade-pr
* fix: upgrade parse from 2.17.0 to 2.18.0

Snyk has created this PR to upgrade parse from 2.17.0 to 2.18.0.

See this package in npm:
https://www.npmjs.com/package/parse

See this project in Snyk:
https://app.snyk.io/org/acinader/project/953c8e1a-a9ef-4134-afbe-43474913abbb?utm_source=github&utm_medium=upgrade-pr

* bump parse to 2.19.0

Co-authored-by: Diamond Lewis <[email protected]>
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8.
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](npm/ini@v1.3.5...v1.3.8)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@pmmlo
Copy link

pmmlo commented Feb 1, 2021

@dblythy What would be the behavior for a distributed deployments? If you have multiple parse-server replicas, wouldn't you simply be fragmenting that single node, unless you have a shared mount volume or universal storage where you are storing Cloud Code?

I think the option to view Parse Cloud Functions is fine, but I think updating Parse Cloud Code should be handled by the end user. Otherwise, you would be limiting the flexibility of how Parse Server can be deployed. What do you think?

@dblythy
Copy link
Member Author

dblythy commented Feb 1, 2021

Good points again @pmmlo, thanks again for reviewing the code and providing insight. You are correct - the editing functionality wouldn't work for distributed deployments. But, I don't think that should mean that the feature shouldn't be available for single instances, where the feature would work as expected.

Maybe we could add a warning, explaining that editing the code only works on single deployments - such as "Editing cloud code is only available on localhost or single deployment servers"? Or, have an option in Parse Server such as singleInstance: true, and the dashboard is a code viewer if it's multi-instance, but editor if it's single instance.

If the consensus is to leave it as cloud code viewing only, I'm happy to revert it to that!

@dblythy
Copy link
Member Author

dblythy commented Feb 1, 2021

@Moumouls made similar points here

@dblythy dblythy marked this pull request as draft February 4, 2021 08:02
davimacedo and others added 4 commits February 7, 2021 19:47
snyk-bot and others added 28 commits August 11, 2021 10:00
* cell select height fix

* cell height refactoring

* row height to match cell height

* refactor height

* removed line height

* cell padding fix

* Cell lineheight fix

* cell spacing -- 2

* Update BrowserCell.scss

* Update Pill.scss

Co-authored-by: Faisal Nadeem <[email protected]>
Co-authored-by: Manuel <[email protected]>
* feat: Sidebar collapse

* fix: Handling app name text-overflow

* fix overlaying JS console line number bar

* removed toolbar ease-in animation

* fixed pin icon padding

* Update CHANGELOG.md

* fixed pinned collapse state

* fixed uncollapsing on mobile

Co-authored-by: Douglas Muraoka <[email protected]>
* get column preference correctly from localstorage

* refreshing after a column is marked visible

* prevent request for always cached fields

* prevent request for password at _User

* set flag cached & making request if not cached

* add cache flag for cached preferences

* refetch data on showAll columns
* cmd+click and context menu

* removed console.log

* fixed pill icon click

* Pill click cleanup

* Delete index.html

* Reverting config.json

Co-authored-by: Faisal Nadeem <[email protected]>
Co-authored-by: Manuel <[email protected]>
* bump version

* Update CHANGELOG.md

* Update CHANGELOG.md

* rebuilt package-lock (npm 6)

* fixed incorrect row height (related to parse-community#1754)

* Update CHANGELOG.md

* Update CHANGELOG.md
* added changelog reminder

* Update CHANGELOG.md

* enforce changelog syntax

* Update ci.yml

* rewording
* add issue bot

* Update CHANGELOG.md
* Update ---1-report-an-issue.md

* Update ---1-report-an-issue.md

* Update CHANGELOG.md
)

* removed old logic

* date time fix

* Changelog.MD update

Added improvement to change-log

* fix changelog entry

* Update CHANGELOG.md

Co-authored-by: Faisal Nadeem <[email protected]>
Co-authored-by: Manuel <[email protected]>
…1774)

Bumps [object-path](https://github.com/mariocasciaro/object-path) from 0.11.5 to 0.11.7.
- [Release notes](https://github.com/mariocasciaro/object-path/releases)
- [Commits](https://github.com/mariocasciaro/object-path/commits)

---
updated-dependencies:
- dependency-name: object-path
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* show pill pointer design for array of pointers

* ctrl+c copy array of pointer value

* encoding data to avoid conversion of object to ParseObjects

* updated changelog.md

* Update CHANGELOG.md

Co-authored-by: Manuel <[email protected]>
* improve ui for array of pointer field

* Updated changelog.md

* Update CHANGELOG.md

Co-authored-by: Manuel <[email protected]>
* bring modal on top of Sidebar

* updated changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.