Allow external authInstance, fixes #751 #1678
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
|
Thanks for the PR. Could you please give an example on how that could be used or, even better, add the example in the repository readme? |
|
Even better; I plan extracting our logic into a GoogleAuthenticator class. But that may take some time, since I have to switch to other things at the moment. |
|
@romanbsd If this PR is still relevant, can you please add a changelog entry and add a README explanation to describe this new config option? |
|
I'm closing this as it seems to lack essential information that is needed to further explore this issue. Feel free to comment if you can provide further details or have any questions and we can re-open this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #751