-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
refactor: remove unused dependencies #1905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove unused dependencies #1905
Conversation
Thanks for opening this pull request!
|
@@ -71,8 +71,7 @@ | |||
"react-router": "5.2.1", | |||
"react-router-dom": "5.3.0", | |||
"regenerator-runtime": "0.13.8", | |||
"semver": "7.3.4", | |||
"typescript": "4.4.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typescript is needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mtrezza could you specify what is using typescript? I checked the repo and there is no configuration for TS, there are no .tsx?
files and no build set up for TS 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
madge uses it; even if you don't see any reference for a dependency in the code base, another dependency may require it based on its configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mtrezza I checked the report madge
generates and everything works.
even if you don't see any reference for a dependency in the code base, another dependency may require it based on its configuration.
Yeah, I get that, I wouldn't try to send the PR otherwise. I checked peer deps of other packages before to be sure if TS is really not required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please resolve the conflict? |
New Pull Request Checklist
Issue Description
Both
typescript
andbabel-plugin-transform-object-rest-spread
are not used anywhere, there is no need to keep them.Related issue: #1902
Approach
TODOs before merging