Skip to content

ci: simplify engine check #2279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,21 +14,21 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ env.NODE_VERSION }}
- name: Use Node.js 12
uses: actions/setup-node@v1
with:
node-version: ${{ env.NODE_VERSION }}
node-version: 12
- name: Cache Node.js modules
uses: actions/cache@v2
with:
path: ~/.npm
key: ${{ runner.os }}-node-${{ env.NODE_VERSION }}-${{ hashFiles('**/package-lock.json') }}
key: ${{ runner.os }}-node-12-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-node-${{ env.NODE_VERSION }}-
${{ runner.os }}-node-12-
- name: Enforce strict engine version
run: echo "engine-strict=true" > .npmrc
- name: Install dependencies
run: npm ci
- name: CI Node Engine Check
run: npm run ci:checkNodeEngine
run: npm install --ignore-scripts
check-lint:
name: Lint
timeout-minutes: 15
Expand Down
183 changes: 153 additions & 30 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
"cross-env": "7.0.2",
"css-loader": "6.5.1",
"eslint": "6.8.0",
"eslint-plugin-jest": "23.8.2",
"eslint-plugin-jest": "27.0.4",
"eslint-plugin-react": "7.19.0",
"http-server": "14.0.0",
"jest": "24.8.0",
Expand Down