Skip to content

refactor: remove unused dependencies #2299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2022
Merged

refactor: remove unused dependencies #2299

merged 1 commit into from
Oct 1, 2022

Conversation

damianstasik
Copy link
Contributor

@damianstasik damianstasik commented Oct 1, 2022 •
edited
Loading

New Pull Request Checklist

Issue Description

Both cross-env and react-redux are not used anymore, no need to keep them in dependencies.

Related issue: #1902

Approach

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Oct 1, 2022 •
edited
Loading

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@mtrezza mtrezza changed the title refactor: remove unused deps refactor: remove unused dependencies Oct 1, 2022
@mtrezza
Copy link
Member

mtrezza commented Oct 1, 2022

As usual, when this is ready for review please request a review.

@damianstasik damianstasik requested a review from a team October 1, 2022 10:24
mtrezza
mtrezza approved these changes Oct 1, 2022
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza merged commit f9bce7f into parse-community:alpha Oct 1, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-alpha.4

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Oct 9, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Oct 17, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@damianstasik @mtrezza @parseplatformorg