Skip to content

fix: using browser navigation backward / forward button clears data browser #2317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 17, 2022
Merged

fix: using browser navigation backward / forward button clears data browser #2317

merged 3 commits into from
Oct 17, 2022

Conversation

damianstasik
Copy link
Contributor

New Pull Request Checklist

Issue Description

This should fix the bug from the attached issue.

Related issue: #2310

Approach

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Oct 12, 2022 •
edited
Loading

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@damianstasik damianstasik requested a review from a team October 14, 2022 12:51
mtrezza
mtrezza reviewed Oct 14, 2022
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're waiting for a comment from @dblythy since he recently added the lines of code this PR would remove.

mtrezza
mtrezza approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; I wasn't able to replicate the issue anymore

@mtrezza mtrezza changed the title fix: issue with data browser and back/forward navigation fix: using browser navigation (backward / forward button) clears data browser Oct 17, 2022
@mtrezza mtrezza changed the title fix: using browser navigation (backward / forward button) clears data browser fix: using browser navigation backward / forward button clears data browser Oct 17, 2022
@mtrezza mtrezza merged commit 7d9b957 into parse-community:alpha Oct 17, 2022
@mtrezza mtrezza linked an issue Oct 17, 2022 that may be closed by this pull request
Using browser navigation clears data browser #2310
Closed
4 tasks
@mtrezza mtrezza mentioned this pull request Oct 17, 2022
Closed
4 tasks
parseplatformorg pushed a commit that referenced this pull request Oct 17, 2022
@semantic-release-bot
chore(release): 5.0.0-alpha.7 [skip ci]
46c29db 
# [5.0.0-alpha.7](5.0.0-alpha.6...5.0.0-alpha.7) (2022-10-17)

### Bug Fixes

* using browser navigation backward / forward button clears data browser ([#2317](#2317)) ([7d9b957](7d9b957))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-alpha.7

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Oct 17, 2022
parseplatformorg pushed a commit that referenced this pull request Oct 17, 2022
@semantic-release-bot
chore(release): 5.0.0-beta.1 [skip ci]
a3bc1d8 
# [5.0.0-beta.1](4.2.0...5.0.0-beta.1) (2022-10-17)

### Bug Fixes

* increase required Node engine version to `>=14.20.1`; this is a breaking change, but will be published as a patch version because the change should have been done with the release of `5.0.0-alpha.1` which has just been released ([#2281](#2281)) ([50de52b](50de52b))
* minor UI layout issues ([#2270](#2270)) ([51d083b](51d083b))
* raw value of read-only date field in data browser cannot be copied ([#2326](#2326)) ([4af7b98](4af7b98))
* using browser navigation backward / forward button clears data browser ([#2317](#2317)) ([7d9b957](7d9b957))

### Features

* improve distinction between deletion confirmation dialogs ([#2319](#2319)) ([23c12ff](23c12ff))
* keep entered filter value when changing filter operator ([#2313](#2313)) ([d6d38bf](d6d38bf))
* remove Node 12 support ([#2277](#2277)) ([18b0e76](18b0e76))

### BREAKING CHANGES

* This version removes support for Node 12; the new minimum required Node version is 14. ([18b0e76](18b0e76))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Oct 17, 2022
parseplatformorg pushed a commit that referenced this pull request Nov 1, 2022
@semantic-release-bot
chore(release): 5.0.0 [skip ci]
98847bb 
# [5.0.0](4.2.0...5.0.0) (2022-11-01)

### Bug Fixes

* increase required Node engine version to `>=14.20.1`; this is a breaking change, but will be published as a patch version because the change should have been done with the release of `5.0.0-alpha.1` which has just been released ([#2281](#2281)) ([50de52b](50de52b))
* minor UI layout issues ([#2270](#2270)) ([51d083b](51d083b))
* raw value of read-only date field in data browser cannot be copied ([#2326](#2326)) ([4af7b98](4af7b98))
* using browser navigation backward / forward button clears data browser ([#2317](#2317)) ([7d9b957](7d9b957))

### Features

* improve distinction between deletion confirmation dialogs ([#2319](#2319)) ([23c12ff](23c12ff))
* keep entered filter value when changing filter operator ([#2313](#2313)) ([d6d38bf](d6d38bf))
* remove Node 12 support ([#2277](#2277)) ([18b0e76](18b0e76))

### BREAKING CHANGES

* This version removes support for Node 12; the new minimum required Node version is 14. ([18b0e76](18b0e76))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Nov 1, 2022
beiguancyc pushed a commit to beiguancyc/parse-dashboard that referenced this pull request Dec 25, 2022
@cycqitianwushuge
Merge branch 'release'
0b9d770 
* release: (41 commits)
  chore(release): 5.0.0 [skip ci]
  ci: release commit
  chore(release): 5.0.0-beta.1 [skip ci]
  chore(release): 5.0.0-alpha.7 [skip ci]
  fix: using browser navigation backward / forward button clears data browser (parse-community#2317)
  docs: update changelog
  chore(release): 5.0.0-alpha.6 [skip ci]
  fix: raw value of read-only date field in data browser cannot be copied (parse-community#2326)
  chore(release): 5.0.0-alpha.5 [skip ci]
  feat: improve distinction between deletion confirmation dialogs (parse-community#2319)
  refactor: upgrade otpauth from 8.0.2 to 8.0.3 (parse-community#2322)
  refactor: upgrade graphiql from 2.0.7 to 2.0.8 (parse-community#2321)
  chore(release): 5.0.0-alpha.4 [skip ci]
  feat: keep entered filter value when changing filter operator (parse-community#2313)
  refactor: upgrade typescript from 4.8.2 to 4.8.3 (parse-community#2308)
  refactor: bump json-schema and jsprim (parse-community#2303)
  refactor: upgrade linting dependencies (parse-community#1946)
  refactor: upgrade semantic-release dependency (parse-community#2301)
  refactor: upgrade React Router to v6 (parse-community#1954)
  refactor: upgrade styling dependencies (parse-community#2300)
  ...

# Conflicts:
#	package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblythy dblythy dblythy requested changes

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using browser navigation clears data browser
4 participants
@damianstasik @parseplatformorg @dblythy @mtrezza