Skip to content

Conversation

@mtrezza
Copy link
Member

@mtrezza mtrezza commented Dec 28, 2025

New Pull Request Checklist

Issue Description

See #3097 (review)

Summary by CodeRabbit

  • Bug Fixes
    • Filters no longer automatically reset pagination to the first page
    • Filters no longer automatically re-apply the current sort order

✏️ Tip: You can customize this high-level summary in your review settings.

@parse-github-assistant
Copy link

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

@coderabbitai
Copy link

coderabbitai bot commented Dec 28, 2025

📝 Walkthrough

Walkthrough

This PR removes two automatic side effects from the filter update flow in the Browser component: pagination reset (skip to 0) and implicit reordering reapplication. The updateFilters method now applies filters independently without triggering state resets or ordering operations.

Changes

Cohort / File(s) Summary
Filter State Management
src/dashboard/Data/Browser/Browser.react.js
Removed automatic skip reset to 0 after filter application; removed implicit updateOrdering invocation in updateFilters method

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description is incomplete; it lacks the 'Approach' and 'TODOs before merging' sections required by the template, and the 'Issue Description' section only contains a link without explanation. Add the 'Approach' section describing the implementation details and fill out the 'TODOs before merging' section to address testing and documentation requirements.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'perf: Remove unnecessary data fetches from data browser pagination' clearly and specifically describes the main change—removing unnecessary data fetches from pagination logic.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 185e674 and b41e52f.

📒 Files selected for processing (1)
  • src/dashboard/Data/Browser/Browser.react.js
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Docker linux/amd64
🔇 Additional comments (2)
src/dashboard/Data/Browser/Browser.react.js (2)

1380-1422: LGTM! Excellent performance optimization.

The refactored updateFilters method now correctly relies on URL-driven navigation to trigger data fetching, eliminating the duplicate fetch that would have occurred from calling updateOrdering explicitly. The skip reset to 0 is properly handled by omitting the skip parameter from the URL (line 1411-1414), which defaults to 0 in extractPaginationFromQuery.


2733-2737: LGTM! Correct handling of limit change.

Explicitly passing 0 for skip when the limit changes ensures pagination resets to the first page, which is the expected behavior. This aligns well with the URL-driven data fetching pattern.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@parseplatformorg
Copy link
Contributor

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@mtrezza mtrezza merged commit bc59998 into parse-community:alpha Dec 28, 2025
12 checks passed
@mtrezza mtrezza deleted the perf/unnecessary-fetches branch December 28, 2025 18:42
parseplatformorg pushed a commit that referenced this pull request Dec 28, 2025
# [8.2.0-alpha.16](8.2.0-alpha.15...8.2.0-alpha.16) (2025-12-28)

### Performance Improvements

* Remove unnecessary data fetches from data browser pagination ([#3098](#3098)) ([bc59998](bc59998))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 8.2.0-alpha.16

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Dec 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:released-alpha Released as alpha version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants