#561: Fixes issue with installation conditions that are pointers #570
Conversation
…e pointers not sending correctly
|
@dvanwinkle updated the pull request - view changes |
dvanwinkle
force-pushed
the
feature/561
branch
from
5a1e25d to
32fb22b
Compare
|
@dvanwinkle updated the pull request - view changes |
|
lgtm. Not sure if we want to save the changelog update until the actual release? Could get confusing @flovilmart ? |
|
There are multiple schools there, Updating the changelog as the PR goes is nice too, so the PR releaser doesn't have to do it :) Many OSS projects do it that way, this document the summary of the changes which is nice. I'd be all in to go in that direction for the dashboard. (and obviously put in in the CONTRIBUTING guide). |
|
I'll happily put it in the CONTRIBUTING guide. I'm a big fan of making this as easy as possible for you all so that we can move faster on releases. I'm also more than happy to help with Release management if you need more people. |
|
now that travis does the releases for us, it's just a matter of tagging :) |
|
But yeah @dvanwinkle I would definitely love any additional involvement :) |
|
Updated CONTRIBUTING in #574 |
|
@flovilmart Anytime, just let me know what you need. |
|
@dvanwinkle thanks for this contribution, been waiting for it for a while, simple small little line of code :) |
|
Folks, can we get a release with this fix anytime soon? Because this is hitting people a lot :P |
Fixes issue #561