Skip to content

Adds commander CLI, improve remote deployments #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2016
Merged

Conversation

flovilmart
Copy link
Contributor

  • Adds support for --config, --port --allowInsecureHTTP
  • Adds support for PARSE_DASHBOARD_ALLOW_INSECURE_HTTP
  • Adds npm start script for easy deployments
  • Adds documentation for running behind HTTPS load balancers

fixes #54

- Adds support for --config, --port --allowInsecureHTTP
- Adds support for PARSE_DASHBOARD_ALLOW_INSECURE_HTTP
- Adds npm start script for easy deployments
@facebook-github-bot
Copy link

By analyzing the blame information on this pull request, we identified @drew-gross, @mnoble and @hallucinogen to be potential reviewers.

@peterdotjs
Copy link
Contributor

nice! could we not reuse the npm run dashboard command rather than use npm start?

@flovilmart
Copy link
Contributor Author

not really as we 'demonize' with & and watch for changes. that breaks the passed command line arguments as they get passed to web pack :(

The ideal scenario would be to have the built dashboard, and just do node dist/index.js

@peterdotjs
Copy link
Contributor

:( lgtm. We're still referencing npm run dashboard elsewhere like in the blog post but we should consolidate the scripts in future. I'm not sure how useful having watch for config changes will be. And it'll be one less script for devs to think about.

@flovilmart
Copy link
Contributor Author

I've updated the README to reference it for 'deployments'.
IMHO, webpack is nice, but is a pain when it comes to copy files.
Not sure what the production.config.js is doing now or if it's supposedly functional

flovilmart added a commit that referenced this pull request Mar 5, 2016
Adds commander CLI, improve remote deployments
@flovilmart flovilmart merged commit c0f745c into master Mar 5, 2016
@flovilmart flovilmart deleted the flovilmart.CLI branch March 5, 2016 16:01
@drew-gross
Copy link
Contributor

npm run dashboard still works. Even if we recommend other ways of running, we should keep that one around since it's handy for hacking on the dashboard.

@flovilmart production.config.js builds minified bundles and enables a custom Babel plugin that removes proptypes. It cuts the size of the bundle from 3.2mb to 1.1mb, which is nice.

@flovilmart
Copy link
Contributor Author

yeah but it don't build a production version in dist/ with the minified that I would use for npm start for example :)

I could add this to web pack so when we run npm run build it creates a dist folder ?

@drew-gross
Copy link
Contributor

Yeah feel free to modify it. I think bundles is the name we should stick with though, no real reason to change it.

@flovilmart
Copy link
Contributor Author

Good! so bundles/parse-dashboard/...

douglasmuraoka pushed a commit that referenced this pull request Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the dashboard experience when deploying to Heroku or other remote machines
4 participants