Fix display of ParseFile in Config #666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 19, 2017
Merged
flovilmart
suggested changes
Feb 19, 2017
| @@ -72,6 +72,8 @@ class Config extends TableView { | |||
| let value = data.value; | |||
| let modalValue = value; | |||
| let type = typeof value; | |||
| let openModalWhenClinkingValue = true; | |||
There was a problem hiding this comment.
remove that and handle in openModal
| } else if (value instanceof Parse.File) { | ||
| type = 'File'; | ||
| value = <a target='_blank' href={value.url()}>Open in new window</a>; | ||
| openModalWhenClinkingValue = false; |
| return ( | ||
| <tr key={data.param}> | ||
| <td style={columnStyle} onClick={openModal}>{data.param}</td> | ||
| <td style={columnStyle} onClick={openModal}>{type}</td> | ||
| <td style={columnStyle} onClick={openModal}>{value}</td> |
| @@ -105,11 +108,19 @@ class Config extends TableView { | |||
| modalValue: modalValue | |||
| }); | |||
| let columnStyle = { width: '30%', cursor: 'pointer' }; | |||
|
|
|||
| let valueColumn; | |||
There was a problem hiding this comment.
remove all that, and check in openModal
let openModal = () => this.setState({
modalOpen: true,
modalParam: data.param,
modalType: type,
modalValue: modalValue
});
// to:
let openModal = () => {
if (modalValue instanceof Parse.File) { return }
this.setState({
modalOpen: true,
modalParam: data.param,
modalType: type,
modalValue: modalValue
});
}
natanrolnik
force-pushed
the
file-display-error
branch
from
e642679 to
d94dda6
Compare
|
@natanrolnik updated the pull request - view changes |
natanrolnik
commented
Feb 20, 2017
| @@ -40,7 +40,7 @@ export default class FileInput extends React.Component { | |||
| render() { | |||
| let inputProps = { | |||
| type: 'file', | |||
| value: null, | |||
There was a problem hiding this comment.
This was generating a warning with files
|
@flovilmart thanks for your review! But I couldn't move the As a plus, I've also fixed the display of GeoPoints! |
flovilmart
approved these changes
Feb 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the display of
Parse.Files and GeoPoints in the Config section of the Dashboard.Now that @flovilmart fixed saving Files to Config in Parse Server (parse-community/parse-server#3457), this is the last bit to have it working in the dashboard.
Before:
After
@JeremyPlease @dvanwinkle @steven-supersolid if anyone of you could review, it would be great.