chore(CI): configure Travis and Codecov (#324)

flovilmart · web-flow · commit 2a967c6790d1 · 2017-06-20T19:22:45.000-04:00
* Create .travis.yml

* Update .travis.yml

* Update .travis.yml

* Update .travis.yml

* Calling nvm in 'before_install'

* using string instead of 'class' property for php 5.4

* Utilizing customary method for accessing json_last_error_msg, in case it doesn't exist (php 5.4)

* Forced installation of 'process-nextick-args' for travis

* Additional comments + force travis to rebuild

* Local install only

* Added missing 'isarray' module

* Shifted travis related dependencies into package.json

* Added 'buffer-shims' module

* Testing with new parse-server-test

* Updated package.json, added slight delay after server boot

* Adds coverage report

* Update README.md
diff --git a/.travis.yml b/.travis.yml
@@ -0,0 +1,22 @@
+language: php
+php:
+  - '5.4'
+  - '5.5'
+  - '5.6'
+  - '7.0'
+  - '7.1'
+#  - hhvm # on Trusty only
+#  - nightly
+before_install:
+  - nvm install 6.11
+install: 
+  - composer install
+  - npm install
+before_script:
+  - npm start 1>&2
+  - sleep 3
+script:
+    - ./vendor/bin/phpunit --coverage-clover=coverage.xml
+
+after_success:
+    - bash <(curl -s https://codecov.io/bash)
diff --git a/README.md b/README.md
@@ -1,6 +1,9 @@
 Parse PHP SDK
 -------------
 
+[![codecov](https://codecov.io/gh/parse-community/parse-php-sdk/branch/master/graph/badge.svg)](https://codecov.io/gh/parse-community/parse-php-sdk)
+[![Build Status](https://travis-ci.org/parse-community/parse-php-sdk.svg?branch=master)](https://travis-ci.org/parse-community/parse-php-sdk)
+
 The Parse PHP SDK gives you access to the powerful Parse cloud platform
 from your PHP app or script.  Updated to work with the self-hosted Parse Server: https://github.com/parse-community/parse-server
 
diff --git a/src/Parse/ParseClient.php b/src/Parse/ParseClient.php
@@ -497,7 +497,7 @@ public static function _request(
         if(!isset($decoded) && $response !== '') {
             throw new ParseException(
                 'Bad Request. Could not decode Response: '.
-                '('.json_last_error().') '.json_last_error_msg(),
+                '('.json_last_error().') '.self::getLastJSONErrorMsg(),
                 -1
             );
 
@@ -522,6 +522,35 @@ public static function _request(
 
     }
 
+    /**
+     * Returns the last error message from a failed json_decode call
+     *
+     * @return string
+     */
+    private static function getLastJSONErrorMsg()
+    {
+        // check if json_last_error_msg is defined (>= 5.5.0)
+        if (!function_exists('json_last_error_msg')) {
+            // return custom error messages for each code
+            $error_strings = array(
+                JSON_ERROR_NONE             => 'No error',
+                JSON_ERROR_DEPTH            => 'Maximum stack depth exceeded',
+                JSON_ERROR_STATE_MISMATCH   => 'State mismatch (invalid or malformed JSON)',
+                JSON_ERROR_CTRL_CHAR        => 'Control character error, potentially incorrectly encoded',
+                JSON_ERROR_SYNTAX           => 'Syntax error',
+                JSON_ERROR_UTF8             => 'Malformed UTF-8 characters, potentially incorrectly encoded'
+            );
+
+            $error = json_last_error();
+            return isset($error_strings[$error]) ? $error_strings[$error] : 'Unknown error';
+
+        }
+
+        // use existing function
+        return json_last_error_msg();
+
+    }
+
     /**
      * ParseClient::setStorage, will update the storage object used for
      * persistence.
diff --git a/tests/Parse/AddOperationTest.php b/tests/Parse/AddOperationTest.php
@@ -40,7 +40,7 @@ public function testAddOperation()
      */
     public function testBadObjects()
     {
-        $this->setExpectedException(ParseException::class,
+        $this->setExpectedException('\Parse\ParseException',
             'AddOperation requires an array.');
         new AddOperation('not an array');
 
@@ -84,7 +84,7 @@ public function testMergePrevious()
      */
     public function testInvalidMerge()
     {
-        $this->setExpectedException(ParseException::class,
+        $this->setExpectedException('\Parse\ParseException',
             'Operation is invalid after previous operation.');
         $addOp = new AddOperation([
             'key1'          => 'value1'
diff --git a/tests/Parse/AddUniqueOperationTest.php b/tests/Parse/AddUniqueOperationTest.php
@@ -50,7 +50,7 @@ public function testAddUniqueOp()
      */
     public function testBadObjects()
     {
-        $this->setExpectedException(ParseException::class,
+        $this->setExpectedException('\Parse\ParseException',
             'AddUniqueOperation requires an array.');
         $addUnique = new AddUniqueOperation('not-an-array');
 
@@ -114,7 +114,7 @@ public function testMergePrevious()
      */
     public function testInvalidMerge()
     {
-        $this->setExpectedException(ParseException::class,
+        $this->setExpectedException('\Parse\ParseException',
             'Operation is invalid after previous operation.');
         $addOp = new AddUniqueOperation([
             'key1'          => 'value1'
diff --git a/tests/Parse/IncrementOperationTest.php b/tests/Parse/IncrementOperationTest.php
@@ -62,7 +62,7 @@ public function testMergePrevious()
      */
     public function testInvalidMerge()
     {
-        $this->setExpectedException(ParseException::class,
+        $this->setExpectedException('\Parse\ParseException',
             'Operation is invalid after previous operation.');
         $addOp = new IncrementOperation();
         $addOp->_mergeWithPrevious(new AddOperation(['key'  => 'value']));
diff --git a/tests/Parse/ParseClientTest.php b/tests/Parse/ParseClientTest.php
@@ -71,7 +71,7 @@ public function testParseNotInitialized() {
      * @group client-not-initialized
      */
     public function testAppNotNotInitialized() {
-        $this->setExpectedException(\Exception::class,
+        $this->setExpectedException('\Exception',
             'You must call Parse::initialize(..., $accountKey) before making any app requests. '.
             'Your account key must not be null or empty.'
         );
@@ -508,7 +508,7 @@ public function testStreamCAFile()
      */
     public function testBadApiResponse()
     {
-        $this->setExpectedException(ParseException::class,
+        $this->setExpectedException('\Parse\ParseException',
             'Bad Request. Could not decode Response: (4) Syntax error');
 
         $httpClient = ParseClient::getHttpClient();
diff --git a/tests/Parse/ParseCurlTest.php b/tests/Parse/ParseCurlTest.php
@@ -16,7 +16,7 @@ class ParseCurlTest extends \PHPUnit_Framework_TestCase
 {
     public function testBadExec()
     {
-        $this->setExpectedException(ParseException::class,
+        $this->setExpectedException('\Parse\ParseException',
             'You must call ParseCurl::init first');
 
         $parseCurl = new ParseCurl();
@@ -26,7 +26,7 @@ public function testBadExec()
 
     public function testBadSetOption()
     {
-        $this->setExpectedException(ParseException::class,
+        $this->setExpectedException('\Parse\ParseException',
             'You must call ParseCurl::init first');
 
         $parseCurl = new ParseCurl();
@@ -36,7 +36,7 @@ public function testBadSetOption()
 
     public function testBadSetOptionsArray()
     {
-        $this->setExpectedException(ParseException::class,
+        $this->setExpectedException('\Parse\ParseException',
             'You must call ParseCurl::init first');
 
         $parseCurl = new ParseCurl();
@@ -46,7 +46,7 @@ public function testBadSetOptionsArray()
 
     public function testBadGetInfo()
     {
-        $this->setExpectedException(ParseException::class,
+        $this->setExpectedException('\Parse\ParseException',
             'You must call ParseCurl::init first');
 
         $parseCurl = new ParseCurl();
@@ -56,7 +56,7 @@ public function testBadGetInfo()
 
     public function testBadGetError()
     {
-        $this->setExpectedException(ParseException::class,
+        $this->setExpectedException('\Parse\ParseException',
             'You must call ParseCurl::init first');
 
         $parseCurl = new ParseCurl();
@@ -66,7 +66,7 @@ public function testBadGetError()
 
     public function testBadErrorCode()
     {
-        $this->setExpectedException(ParseException::class,
+        $this->setExpectedException('\Parse\ParseException',
             'You must call ParseCurl::init first');
 
         $parseCurl = new ParseCurl();
@@ -76,7 +76,7 @@ public function testBadErrorCode()
 
     public function testBadClose()
     {
-        $this->setExpectedException(ParseException::class,
+        $this->setExpectedException('\Parse\ParseException',
             'You must call ParseCurl::init first');
 
         $parseCurl = new ParseCurl();
diff --git a/tests/Parse/ParseInstallationTest.php b/tests/Parse/ParseInstallationTest.php
@@ -23,7 +23,7 @@ public function tearDown()
      */
     public function testMissingIdentifyingField()
     {
-        $this->setExpectedException(ParseException::class,
+        $this->setExpectedException('\Parse\ParseException',
             'at least one ID field (deviceToken, installationId) must be specified in this operation');
 
         (new ParseInstallation())->save();
@@ -34,7 +34,7 @@ public function testMissingIdentifyingField()
      */
     public function testMissingDeviceType()
     {
-        $this->setExpectedException(ParseException::class,
+        $this->setExpectedException('\Parse\ParseException',
             'deviceType must be specified in this operation');
 
         $installation = new ParseInstallation();
@@ -48,7 +48,7 @@ public function testMissingDeviceType()
      */
     public function testClientsCannotFindWithoutMasterKey()
     {
-        $this->setExpectedException(ParseException::class,
+        $this->setExpectedException('\Parse\ParseException',
             'Clients aren\'t allowed to perform the find operation on the installation collection.');
 
         $query = ParseInstallation::query();
@@ -66,7 +66,7 @@ public function testClientsCannotDestroyWithoutMasterKey()
         $installation->set('deviceType', 'android');
         $installation->save();
 
-        $this->setExpectedException(ParseException::class,
+        $this->setExpectedException('\Parse\ParseException',
             "Clients aren't allowed to perform the delete operation on the installation collection.");
 
         // try destroying, without using the master key
diff --git a/tests/Parse/ParsePushTest.php b/tests/Parse/ParsePushTest.php
@@ -21,7 +21,7 @@ public function tearDown()
     }
 
     public function testNoMasterKey() {
-        $this->setExpectedException(ParseException::class);
+        $this->setExpectedException('\Parse\ParseException');
 
         ParsePush::send(
             [
@@ -46,7 +46,7 @@ public function testBasicPush()
      */
     public function testMissingWhereAndChannels()
     {
-        $this->setExpectedException(ParseException::class,
+        $this->setExpectedException('\Parse\ParseException',
             "Sending a push requires either \"channels\" or a \"where\" query.");
 
         ParsePush::send([
@@ -62,7 +62,7 @@ public function testMissingWhereAndChannels()
      */
     public function testWhereAndChannels()
     {
-        $this->setExpectedException(ParseException::class,
+        $this->setExpectedException('\Parse\ParseException',
             "Channels and query can not be set at the same time.");
 
         $query = ParseInstallation::query();
@@ -108,7 +108,7 @@ public function testPushToQueryWithoutWhere()
 
     public function testNonQueryWhere()
     {
-        $this->setExpectedException(\Exception::class,
+        $this->setExpectedException('\Exception',
             'Where parameter for Parse Push must be of type ParseQuery');
         ParsePush::send(
             [
@@ -133,7 +133,7 @@ public function testPushDates()
 
     public function testExpirationTimeAndIntervalSet()
     {
-        $this->setExpectedException(\Exception::class,
+        $this->setExpectedException('\Exception',
             'Both expiration_time and expiration_interval can\'t be set.');
         ParsePush::send(
             [
diff --git a/tests/Parse/ParseQueryTest.php b/tests/Parse/ParseQueryTest.php
@@ -2243,7 +2243,7 @@ public function testAscendingByArray() {
 
     public function testOrQueriesVaryingClasses()
     {
-        $this->setExpectedException(\Exception::class,
+        $this->setExpectedException('\Exception',
             'All queries must be for the same class');
         ParseQuery::orQueries([
             new ParseQuery('Class1'),
@@ -2275,7 +2275,7 @@ public function testSetConditions()
 
     public function testBadConditions()
     {
-        $this->setExpectedException(ParseException::class,
+        $this->setExpectedException('\Parse\ParseException',
             "Conditions must be in an array");
 
         $query = new ParseQuery('TestObject');
diff --git a/tests/Parse/ParseRelationOperationTest.php b/tests/Parse/ParseRelationOperationTest.php
@@ -30,7 +30,7 @@ public function tearDown()
      */
     public function testMissingObjects()
     {
-        $this->setExpectedException(\Exception::class,
+        $this->setExpectedException('\Exception',
             'Cannot create a ParseRelationOperation with no objects.');
         new ParseRelationOperation(null, null);
 
@@ -41,7 +41,7 @@ public function testMissingObjects()
      */
     public function testMixedClasses()
     {
-        $this->setExpectedException(\Exception::class,
+        $this->setExpectedException('\Exception',
             'All objects in a relation must be of the same class.');
 
         $objects = [];
@@ -78,7 +78,7 @@ public function testSingleObjects()
      */
     public function testApplyDifferentClassRelation()
     {
-        $this->setExpectedException(\Exception::class,
+        $this->setExpectedException('\Exception',
             'Related object object must be of class '
             .'Class1, but DifferentClass'
             .' was passed in.');
@@ -96,7 +96,7 @@ public function testApplyDifferentClassRelation()
      */
     public function testInvalidApply()
     {
-        $this->setExpectedException(\Exception::class,
+        $this->setExpectedException('\Exception',
             'Operation is invalid after previous operation.');
         $addObj = new ParseObject('Class1');
         $op = new ParseRelationOperation($addObj, null);
@@ -120,7 +120,7 @@ public function testMergeNone()
      */
     public function testMergeDifferentClass()
     {
-        $this->setExpectedException(\Exception::class,
+        $this->setExpectedException('\Exception',
             'Related object object must be of class '
             .'Class1, but AnotherClass'
             .' was passed in.');
@@ -140,7 +140,7 @@ public function testMergeDifferentClass()
      */
     public function testInvalidMerge()
     {
-        $this->setExpectedException(\Exception::class,
+        $this->setExpectedException('\Exception',
             'Operation is invalid after previous operation.');
         $obj = new ParseObject('Class1');
         $op = new ParseRelationOperation($obj, null);
diff --git a/tests/Parse/ParseRoleTest.php b/tests/Parse/ParseRoleTest.php
@@ -235,7 +235,7 @@ public function createEden()
 
     public function testSettingNonStringAsName()
     {
-        $this->setExpectedException(ParseException::class,
+        $this->setExpectedException('\Parse\ParseException',
             "A role's name must be a string.");
         $role = new ParseRole();
         $role->setName(12345);
@@ -247,7 +247,7 @@ public function testSettingNonStringAsName()
      */
     public function testSavingWithoutName()
     {
-        $this->setExpectedException(ParseException::class,
+        $this->setExpectedException('\Parse\ParseException',
             'Roles must have a name.');
         $role = new ParseRole();
         $role->setACL(new ParseACL());
diff --git a/tests/Parse/ParseSchemaTest.php b/tests/Parse/ParseSchemaTest.php
diff --git a/tests/Parse/ParseSessionStorageAltTest.php b/tests/Parse/ParseSessionStorageAltTest.php
diff --git a/tests/Parse/ParseStreamHttpClientTest.php b/tests/Parse/ParseStreamHttpClientTest.php
diff --git a/tests/Parse/RemoveOperationTest.php b/tests/Parse/RemoveOperationTest.php

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ public function testMergePrevious()`
`62`	`62`	`*/`
`63`	`63`	`public function testInvalidMerge()`
`64`	`64`	`{`
`65`		`- $this->setExpectedException(ParseException::class,`
	`65`	`+ $this->setExpectedException('\Parse\ParseException',`
`66`	`66`	`'Operation is invalid after previous operation.');`
`67`	`67`	`$addOp = new IncrementOperation();`
`68`	`68`	`$addOp->_mergeWithPrevious(new AddOperation(['key' => 'value']));`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ class ParseCurlTest extends \PHPUnit_Framework_TestCase`
`16`	`16`	`{`
`17`	`17`	`public function testBadExec()`
`18`	`18`	`{`
`19`		`- $this->setExpectedException(ParseException::class,`
	`19`	`+ $this->setExpectedException('\Parse\ParseException',`
`20`	`20`	`'You must call ParseCurl::init first');`
`21`	`21`
`22`	`22`	`$parseCurl = new ParseCurl();`
`@@ -26,7 +26,7 @@ public function testBadExec()`
`26`	`26`
`27`	`27`	`public function testBadSetOption()`
`28`	`28`	`{`
`29`		`- $this->setExpectedException(ParseException::class,`
	`29`	`+ $this->setExpectedException('\Parse\ParseException',`
`30`	`30`	`'You must call ParseCurl::init first');`
`31`	`31`
`32`	`32`	`$parseCurl = new ParseCurl();`
`@@ -36,7 +36,7 @@ public function testBadSetOption()`
`36`	`36`
`37`	`37`	`public function testBadSetOptionsArray()`
`38`	`38`	`{`
`39`		`- $this->setExpectedException(ParseException::class,`
	`39`	`+ $this->setExpectedException('\Parse\ParseException',`
`40`	`40`	`'You must call ParseCurl::init first');`
`41`	`41`
`42`	`42`	`$parseCurl = new ParseCurl();`
`@@ -46,7 +46,7 @@ public function testBadSetOptionsArray()`
`46`	`46`
`47`	`47`	`public function testBadGetInfo()`
`48`	`48`	`{`
`49`		`- $this->setExpectedException(ParseException::class,`
	`49`	`+ $this->setExpectedException('\Parse\ParseException',`
`50`	`50`	`'You must call ParseCurl::init first');`
`51`	`51`
`52`	`52`	`$parseCurl = new ParseCurl();`
`@@ -56,7 +56,7 @@ public function testBadGetInfo()`
`56`	`56`
`57`	`57`	`public function testBadGetError()`
`58`	`58`	`{`
`59`		`- $this->setExpectedException(ParseException::class,`
	`59`	`+ $this->setExpectedException('\Parse\ParseException',`
`60`	`60`	`'You must call ParseCurl::init first');`
`61`	`61`
`62`	`62`	`$parseCurl = new ParseCurl();`
`@@ -66,7 +66,7 @@ public function testBadGetError()`
`66`	`66`
`67`	`67`	`public function testBadErrorCode()`
`68`	`68`	`{`
`69`		`- $this->setExpectedException(ParseException::class,`
	`69`	`+ $this->setExpectedException('\Parse\ParseException',`
`70`	`70`	`'You must call ParseCurl::init first');`
`71`	`71`
`72`	`72`	`$parseCurl = new ParseCurl();`
`@@ -76,7 +76,7 @@ public function testBadErrorCode()`
`76`	`76`
`77`	`77`	`public function testBadClose()`
`78`	`78`	`{`
`79`		`- $this->setExpectedException(ParseException::class,`
	`79`	`+ $this->setExpectedException('\Parse\ParseException',`
`80`	`80`	`'You must call ParseCurl::init first');`
`81`	`81`
`82`	`82`	`$parseCurl = new ParseCurl();`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ public function tearDown()`
`21`	`21`	`}`
`22`	`22`
`23`	`23`	`public function testNoMasterKey() {`
`24`		`- $this->setExpectedException(ParseException::class);`
	`24`	`+ $this->setExpectedException('\Parse\ParseException');`
`25`	`25`
`26`	`26`	`ParsePush::send(`
`27`	`27`	`[`
`@@ -46,7 +46,7 @@ public function testBasicPush()`
`46`	`46`	`*/`
`47`	`47`	`public function testMissingWhereAndChannels()`
`48`	`48`	`{`
`49`		`- $this->setExpectedException(ParseException::class,`
	`49`	`+ $this->setExpectedException('\Parse\ParseException',`
`50`	`50`	`"Sending a push requires either \"channels\" or a \"where\" query.");`
`51`	`51`
`52`	`52`	`ParsePush::send([`
`@@ -62,7 +62,7 @@ public function testMissingWhereAndChannels()`
`62`	`62`	`*/`
`63`	`63`	`public function testWhereAndChannels()`
`64`	`64`	`{`
`65`		`- $this->setExpectedException(ParseException::class,`
	`65`	`+ $this->setExpectedException('\Parse\ParseException',`
`66`	`66`	`"Channels and query can not be set at the same time.");`
`67`	`67`
`68`	`68`	`$query = ParseInstallation::query();`
`@@ -108,7 +108,7 @@ public function testPushToQueryWithoutWhere()`
`108`	`108`
`109`	`109`	`public function testNonQueryWhere()`
`110`	`110`	`{`
`111`		`- $this->setExpectedException(\Exception::class,`
	`111`	`+ $this->setExpectedException('\Exception',`
`112`	`112`	`'Where parameter for Parse Push must be of type ParseQuery');`
`113`	`113`	`ParsePush::send(`
`114`	`114`	`[`
`@@ -133,7 +133,7 @@ public function testPushDates()`
`133`	`133`
`134`	`134`	`public function testExpirationTimeAndIntervalSet()`
`135`	`135`	`{`
`136`		`- $this->setExpectedException(\Exception::class,`
	`136`	`+ $this->setExpectedException('\Exception',`
`137`	`137`	`'Both expiration_time and expiration_interval can\'t be set.');`
`138`	`138`	`ParsePush::send(`
`139`	`139`	`[`
Original file line number	Diff line number	Diff line change
`@@ -2243,7 +2243,7 @@ public function testAscendingByArray() {`
`2243`	`2243`
`2244`	`2244`	`public function testOrQueriesVaryingClasses()`
`2245`	`2245`	`{`
`2246`		`- $this->setExpectedException(\Exception::class,`
	`2246`	`+ $this->setExpectedException('\Exception',`
`2247`	`2247`	`'All queries must be for the same class');`
`2248`	`2248`	`ParseQuery::orQueries([`
`2249`	`2249`	`new ParseQuery('Class1'),`
`@@ -2275,7 +2275,7 @@ public function testSetConditions()`
`2275`	`2275`
`2276`	`2276`	`public function testBadConditions()`
`2277`	`2277`	`{`
`2278`		`- $this->setExpectedException(ParseException::class,`
	`2278`	`+ $this->setExpectedException('\Parse\ParseException',`
`2279`	`2279`	`"Conditions must be in an array");`
`2280`	`2280`
`2281`	`2281`	`$query = new ParseQuery('TestObject');`