Skip to content

Create .travis.yml #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jun 20, 2017
Merged

Create .travis.yml #324

merged 17 commits into from
Jun 20, 2017

Conversation

flovilmart
Copy link
Contributor

No description provided.

@montymxb
Copy link
Contributor

I'll have to tinker with this to get the builds passing, but thanks for setting this up again!

@flovilmart
Copy link
Contributor Author

@montymxb I checked the CONTRIBUTING.md file and try to set it up accordingly we'll see :)

@montymxb
Copy link
Contributor

I was just looking at those changes. I think that should do it! Essentially composer/npm wrap up our dependencies, and npm start fires up the test server. Assuming the server can bind and is reachable we'll have to see how Travis works with it...

@flovilmart
Copy link
Contributor Author

we need node 6 installed and it ships with node 0.10... nvm is no installed either

@montymxb
Copy link
Contributor

montymxb commented Jun 20, 2017

brew isn't present either :/, I think there's an easier way to load up npm. I think there's a built in way to include it, I'm looking at the moment.

@flovilmart
Copy link
Contributor Author

ok! Don't hesitate to edit updateSessionUpdateTime on that branch directly.

@montymxb
Copy link
Contributor

montymxb commented Jun 20, 2017

It looks like nvm is actually installed, as it gave N/A version is not installed yet. But it looks like if you want to set it up you can run it under the before_install section. No guarantees but it would seem to work.

before_install:
  - nvm install 6.0

And ah I see you made the branch here. Yeah I'll go ahead and put this up and see what happens.

@flovilmart
Copy link
Contributor Author

Ahah it works! But there are some PHP errors:

PHP Parse error:  syntax error, unexpected 'class' (T_CLASS), expecting identifier (T_STRING) or variable (T_VARIABLE) or '{' or '$' in /home/travis/build/parse-community/parse-php-sdk/tests/Parse/AddOperationTest.php on line 43

@montymxb
Copy link
Contributor

Progress! I'll take a quick look and patch that syntax issue up. As for the other tests looks like syntax is acceptable but the server is not reachable.

Parse\ParseException: couldn't connect to host

Either it's running or it's not able to connect, with the process in the background it's hard to tell. I'll see what I can do about that.

@flovilmart
Copy link
Contributor Author

flovilmart commented Jun 20, 2017

it's possible that the server is not running anymore :/ or actually never ran:  Cannot find module 'process-nextick-args' 

@montymxb
Copy link
Contributor

Ahhh, good catch. We may have to manually include that dependency if Travis CI is missing it for some reason, assuming that's the issue.

@flovilmart
Copy link
Contributor Author

yeah that's odd

Copy link
Contributor Author

@flovilmart flovilmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add those to your testing package .)

@montymxb
Copy link
Contributor

Probably, they don't seem to be a problem when we're not running travis but it certainly wouldn't hurt.

@montymxb
Copy link
Contributor

I'll leave them in this package.json for the moment, just to get this sorted out. Once that looks good I'll shift them down as a dependency in the parse-server-test repo.

@montymxb montymxb mentioned this pull request Jun 20, 2017
@codecov
Copy link

codecov bot commented Jun 20, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@9bdbd71). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #324   +/-   ##
=========================================
  Coverage          ?   98.03%           
=========================================
  Files             ?       35           
  Lines             ?     2702           
  Branches          ?        0           
=========================================
  Hits              ?     2649           
  Misses            ?       53           
  Partials          ?        0
Impacted Files Coverage Δ
src/Parse/ParseClient.php 98.93% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bdbd71...a151141. Read the comment docs.

@flovilmart
Copy link
Contributor Author

@montymxb Awesome Job man! That's rocking! I just added the codecov badge and travis!

Copy link
Contributor

@montymxb montymxb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! README is updated and everything, and codecov too 👍. Can't think of much else that we would need. We should have a baseline for codecov on the next run so it looks good to me!

@flovilmart flovilmart merged commit 2a967c6 into master Jun 20, 2017
@flovilmart flovilmart deleted the travis branch June 20, 2017 23:22
@flovilmart
Copy link
Contributor Author

flovilmart commented Jun 20, 2017 via email

@montymxb
Copy link
Contributor

@flovilmart thanks again for helping get Travis setup! That's fantastic to hear we're one of the most covered sdks too 💯 . Always good to keep the test coverage up!

@flovilmart
Copy link
Contributor Author

No problem! Glad to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants