-
-
Notifications
You must be signed in to change notification settings - Fork 342
Create .travis.yml #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create .travis.yml #324
Conversation
I'll have to tinker with this to get the builds passing, but thanks for setting this up again! |
@montymxb I checked the CONTRIBUTING.md file and try to set it up accordingly we'll see :) |
I was just looking at those changes. I think that should do it! Essentially composer/npm wrap up our dependencies, and npm start fires up the test server. Assuming the server can bind and is reachable we'll have to see how Travis works with it... |
we need node 6 installed and it ships with node 0.10... nvm is no installed either |
brew isn't present either :/, I think there's an easier way to load up npm. I think there's a built in way to include it, I'm looking at the moment. |
ok! Don't hesitate to edit updateSessionUpdateTime on that branch directly. |
It looks like nvm is actually installed, as it gave before_install:
- nvm install 6.0 And ah I see you made the branch here. Yeah I'll go ahead and put this up and see what happens. |
Ahah it works! But there are some PHP errors:
|
Progress! I'll take a quick look and patch that syntax issue up. As for the other tests looks like syntax is acceptable but the server is not reachable.
Either it's running or it's not able to connect, with the process in the background it's hard to tell. I'll see what I can do about that. |
it's possible that the server is not running anymore :/ or actually never ran: |
… it doesn't exist (php 5.4)
Ahhh, good catch. We may have to manually include that dependency if Travis CI is missing it for some reason, assuming that's the issue. |
yeah that's odd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably add those to your testing package .)
Probably, they don't seem to be a problem when we're not running travis but it certainly wouldn't hurt. |
I'll leave them in this package.json for the moment, just to get this sorted out. Once that looks good I'll shift them down as a dependency in the parse-server-test repo. |
Codecov Report
@@ Coverage Diff @@
## master #324 +/- ##
=========================================
Coverage ? 98.03%
=========================================
Files ? 35
Lines ? 2702
Branches ? 0
=========================================
Hits ? 2649
Misses ? 53
Partials ? 0
Continue to review full report at Codecov.
|
@montymxb Awesome Job man! That's rocking! I just added the codecov badge and travis! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! README is updated and everything, and codecov too 👍. Can't think of much else that we would need. We should have a baseline for codecov on the next run so it looks good to me!
That’s awesome! From the coverage perspective the SDK is one of the best we have! Glad we can get the CI to help out. If you need anything else, I’m just round the corner!
…On Jun 20, 2017, 19:21 -0400, Benjamin Wilson Friedman ***@***.***>, wrote:
@montymxb approved this pull request.
Nice! README is updated and everything, and codecov too 👍. Can't think of much else that we would need. We should have baseline for codecov on the next run so it looks good to me!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@flovilmart thanks again for helping get Travis setup! That's fantastic to hear we're one of the most covered sdks too 💯 . Always good to keep the test coverage up! |
No problem! Glad to help! |
No description provided.