Adds specific error codes to certain ParseExceptions #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #334 +/- ##
==========================================
+ Coverage 98.78% 98.79% +<.01%
==========================================
Files 35 35
Lines 2727 2749 +22
==========================================
+ Hits 2694 2716 +22
Misses 33 33
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #180 some time ago, some of the exceptions thrown from this SDK should be setting errors codes as documented in the guide. Not all the exceptions can associate to codes that would make sense, so I have only modified those that are relevant.
If there are any other exceptions that anyone thinks could still use a relevant code go ahead and comment on it. Same for if there are any concerns with some of the exception/code pairings that I've made.
This PR makes no changes to the existing functionality and no new tests were added, just further details for exception handling.