Skip to content

fix: Reintroduce babel transcompiler #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Jul 8, 2024

New Pull Request Checklist

Issue Description

The server isn't compatible with ES6 modules. This PR transcompiles the project to CommonJS. In the future we could look into rollup as we might have to do this with the JS SDK.

https://github.com/parse-community/parse-server/actions/runs/9831140057/job/27138118586?pr=9182

Approach

  • Tested in Production
  • Fixes Runtime Generator not found error
  • Runs tests against lib instead of src
  • Use nyc for coverage
  • Use latest version of Babel

Copy link

parse-github-assistant bot commented Jul 8, 2024

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@mtrezza mtrezza changed the title feat: Reintroduce Babel fix: Reintroduce babel transcompiler Jul 8, 2024
@mtrezza
Copy link
Member

mtrezza commented Jul 8, 2024

@mtrezza
Copy link
Member

mtrezza commented Jul 8, 2024

So this can be closed thanks to parse-community/parse-server#9182 (comment), right?

@dplewis
Copy link
Member Author

dplewis commented Jul 8, 2024

Yeah

@dplewis dplewis closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants