Fixed error when sending pushes to one pushType #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added check for empty devices sets when sending push notifications to senders. This fixes and issue where the empty sets being processed by the senders would throw several reference errors.
3 tasks
Current coverage is
|
| } | ||
| if(devices.length > 0) | ||
| { | ||
| if (!sender) { |
There was a problem hiding this comment.
can you use spaces instead of tabs and length 2 instead of 4?
|
One small nit otherwise LGTM |
| } else { | ||
| sendPromises.push(sender.send(data, devices)); | ||
| } | ||
| if(devices.length > 0) |
There was a problem hiding this comment.
can you use Array.isArray(devices) && devices.length > 0 instead? This way we'll completely eliminate any possible problems,
Replaced tabs with spaces Added array check for device set
|
Tabs have been replaced with spaces (length =2). And the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added check for empty devices sets when sending push notifications to
senders. This fixes and issue where the empty sets being processed by
the senders would throw several reference errors.
Fixes parse-community/parse-server#1245