BadValue Too many geoNear expressions in 2.3.8

[gs-sramesh]

Issue Description

All geo queries near, withinMiles etc fail with the error:

 Uncaught internal server error. { MongoError: Can't canonicalize query: BadValue Too many geoNear expressions

The same used to work previously under parse version 2.3.0

Steps to reproduce

var query = new Parse.Query("User"); // Or any other clss
var point = new Parse.GeoPoint({
      latitude: location.lat || 0,
      longitude: location.lon || 0
    });
query.withinMiles("location", point, 75);

Expected Results

Should work as it did under version 2.3.0

Actual Outcome

Error on Mongo

Environment Setup

• Server

  • parse-server version (Be specific! Don't say 'latest'.) : 2.3.8
  • Operating System: OSX Sierra
  • Hardware:
  • Localhost or remote server? (AWS, Heroku, Azure, Digital Ocean, etc): localhost

• Database

  • MongoDB version: MongoDB shell version: 3.0.12

  • Storage engine: [FILL THIS OUT]

  • Hardware: [FILL THIS OUT]

  • Localhost or remote server? (AWS, mLab, ObjectRocket, Digital Ocean, etc): [FILL THIS OUT]

Logs/Trace

Include all relevant logs. You can turn on additional logging by configuring VERBOSE=1 in your environment.

error: Uncaught internal server error. { MongoError: Can't canonicalize query: BadValue Too many geoNear expressions
    at Function.MongoError.create (/Users/sramesh/Desktop/code/m2e/cloud/parse-backend/parse/node_modules/mongodb-core/lib/error.js:31:11)
    at queryCallback (/Users/sramesh/Desktop/code/m2e/cloud/parse-backend/parse/node_modules/mongodb-core/lib/cursor.js:197:34)
    at /Users/sramesh/Desktop/code/m2e/cloud/parse-backend/parse/node_modules/mongodb-core/lib/connection/pool.js:461:18
    at _combinedTickCallback (internal/process/next_tick.js:67:7)
    at process._tickDomainCallback (internal/process/next_tick.js:122:9)
  name: 'MongoError',
  message: 'Can\'t canonicalize query: BadValue Too many geoNear expressions',
  '$err': 'Can\'t canonicalize query: BadValue Too many geoNear expressions',
  code: 17287 } MongoError: Can't canonicalize query: BadValue Too many geoNear expressions
    at Function.MongoError.create (/Users/sramesh/Desktop/code/m2e/cloud/parse-backend/parse/node_modules/mongodb-core/lib/error.js:31:11)
    at queryCallback (/Users/sramesh/Desktop/code/m2e/cloud/parse-backend/parse/node_modules/mongodb-core/lib/cursor.js:197:34)
    at /Users/sramesh/Desktop/code/m2e/cloud/parse-backend/parse/node_modules/mongodb-core/lib/connection/pool.js:461:18
    at _combinedTickCallback (internal/process/next_tick.js:67:7)
    at process._tickDomainCallback (internal/process/next_tick.js:122:9)
MongoError: Can't canonicalize query: BadValue Too many geoNear expressions
    at Function.MongoError.create (/Users/sramesh/Desktop/code/m2e/cloud/parse-backend/parse/node_modules/mongodb-core/lib/error.js:31:11)
    at queryCallback (/Users/sramesh/Desktop/code/m2e/cloud/parse-backend/parse/node_modules/mongodb-core/lib/cursor.js:197:34)
    at /Users/sramesh/Desktop/code/m2e/cloud/parse-backend/parse/node_modules/mongodb-core/lib/connection/pool.js:461:18
    at _combinedTickCallback (internal/process/next_tick.js:67:7)
    at process._tickDomainCallback (internal/process/next_tick.js:122:9)

[srameshr]

@flovilmart Anything on this?

[flovilmart]

Can your provide the logs when running with VERBOSE=1? This will log the full query. We have many tests covering the geoPoints. I'm not sure why your particular query fails

[srameshr]

verbose: REQUEST for [GET] /parse/classes/MyClass: {
  "where": {
    "$or": [
      {
        "MyClassDate": {
          "$gte": "2017-05-01T12:39:38.500Z"
        }
      },
      {
        "MyClassDate": null
      }
    ],
    "rLoc": {
      "$nearSphere": {
        "__type": "GeoPoint",
        "latitude": 40,
        "longitude": -30
      }
    }
  },
  "include": "createdBy",
  "keys": "MyClassDate,rCity",
  "limit": 10
} method=GET, url=/parse/classes/MyClass, user-agent=node-XMLHttpRequest, Parse/js1.9.2 (NodeJS 6.4.0), accept=*/*, content-type=text/plain, host=localhost:1337, content-length=471, connection=close, $or=[$gte=2017-05-01T12:39:38.500Z, MyClassDate=null], __type=GeoPoint, latitude=40, longitude=-30, include=createdBy, keys=MyClassDate,rCity, limit=10
error: Error generating response. { MongoError: Can't canonicalize query: BadValue Too many geoNear expressions
    at Function.MongoError.create (/Users/sramesh/Desktop/code/m2e/cloud/parse-backend/parse/node_modules/mongodb-core/lib/error.js:31:11)
    at queryCallback (/Users/sramesh/Desktop/code/m2e/cloud/parse-backend/parse/node_modules/mongodb-core/lib/cursor.js:197:34)
    at /Users/sramesh/Desktop/code/m2e/cloud/parse-backend/parse/node_modules/mongodb-core/lib/connection/pool.js:461:18
    at _combinedTickCallback (internal/process/next_tick.js:67:7)
    at process._tickDomainCallback (internal/process/next_tick.js:122:9)
  name: 'MongoError',
  message: 'Can\'t canonicalize query: BadValue Too many geoNear expressions',
  '$err': 'Can\'t canonicalize query: BadValue Too many geoNear expressions',
  code: 17287 } name=MongoError, message=Can't canonicalize query: BadValue Too many geoNear expressions, $err=Can't canonicalize query: BadValue Too many geoNear expressions, code=17287

@flovilmart

[srameshr]

@flovilmart Anything on this?

[flovilmart]

I don't believe you can use geonear alongside $or as part of a restriction on mongodb

[srameshr]

@flovilmart It used to work all right until i updated my parse server version to 2.3.8

[flovilmart]

Can you provide the exact client code that trigger this issue?

[srameshr]

Parse.Cloud.run('searchWithLocation', {
            'location': location, // lat and lon
            'date':date // JS date object
          })

@flovilmart

[srameshr]

Anyone who updated to 2.3.8 is facing the same?

[flovilmart]

And what's the query that's being done in cloud code?

[srameshr]

var location = request.params.location,
    date = request.params.date;

    var myClass = Parse.Object.extend("Class"),
    q1 = new Parse.Query(myClass);

    q1.greaterThanOrEqualTo("dated", date); // 6 hours before

    var q2 = new Parse.Query(Class1);
    q2.equalTo('dated', null);


    var query = Parse.Query.or(q1, q2),
    point = new Parse.GeoPoint({latitude: 40.0, longitude: -30.0});
    query.near("rLoc", point);
    query.include("createdBy");
    query.find().then(success, failure);

[flovilmart]

The point variable is unused, can you provide the exact code please so I can write a proper test and check against previous versions?

[srameshr]

@flovilmart I have edited the previous comment.

[flovilmart]

I'll run the tests against 2.3.7 to try to indentify where / if a regression occured