Skip to content

PushAdapter for Urban Airship #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jashsayani opened this issue Feb 14, 2016 · 15 comments
Closed

PushAdapter for Urban Airship #404

jashsayani opened this issue Feb 14, 2016 · 15 comments

Comments

@jashsayani
Copy link

It would be nice to have a PushAdapter for Urban Airship, since its a mainstream push management platform and has been in the space for a long time.

@gfosco
Copy link
Contributor

gfosco commented Feb 14, 2016

Now that there's a push adapter system, it should be pretty straight-forward. OneSignal already jumped on that with #405, and would be a good example.

@jashsayani
Copy link
Author

@jarofghosts Is UA planning on an official adapter?

@mherrick66
Copy link

We're certainly open to it @jashsayani if there is enough interest in that from the Parse community. We created this Parse Importer Tool over the last couple weeks that helps with the data side/migration: https://www.urbanairship.com/blog/announcing-urban-airships-parse-importer-tool

@jashsayani
Copy link
Author

@mherrick66 I did not know about the Importer Tool, will check it out. I would think that a PushAdapter for UA would definitely be useful for a lot of people (in terms of getting UA users). Currently OneSignal is the only other provider working on it, so I would expect a fair share pick UA.

@flovilmart
Copy link
Contributor

@jashsayani @mherrick66 @gfosco do we want all those adapter in the core code base? Given the context in which Parse is shutting down, I believe for the moment the core code base should focus on code/feature parity and allow extensibility through 3rd party node modules as discussed in #290 an others.

In that sense, I've opened https://github.com/parse-server-modules to help manage those 3rd parties dependencies, declutter the review process here and increase the bandwidth.

This way, those adapters won't need core team reviews, and we'll move faster on any non-core features.

@flovilmart
Copy link
Contributor

Implemented here: https://github.com/flovilmart/parse-server-urban-airship, you can install via NPM and configure externally.
Let me know how it's working for you @jashsayani

@jashsayani
Copy link
Author

@flovilmart Thanks. I'll try it out on the weekend.

@flovilmart
Copy link
Contributor

@jashsayani wonderful! Don't hesitate to post issues on the repo directly to unclutter this one.

@edwardyue
Copy link

Any guide for helping to configure UA or Onesignal as PushAdapter?

Is it simple to amend bin/parse-server file?

@flovilmart
Copy link
Contributor

check the README, the bin/parse-server hasn't been updated to support push yet.

@edwardyue
Copy link

i understand the current bin/parse-server, thats why i want to make use of OneSignal.

I got this [Error]: Push adapter is not availabe (Code: 115, Version: 1.12.0) for my iPhone app. any idea to implement the PushAdapter properly?

Thanks!

@edwardyue
Copy link

I have amended bin/parse-server like below, any comment

// Make push adapter
//let pushConfig = args.push;
//let pushAdapter;
//if (pushConfig && pushConfig.adapter) {
// pushAdapter = pushConfig.adapter;
//} else if (pushConfig) {
// pushAdapter = new ParsePushAdapter(pushConfig)
// }

pushAdapter = new OneSignalPushAdapter(pushConfig)

@flovilmart
Copy link
Contributor

@edwardyue you should not amend the bin/parse-server but have your 'package' with your app, that use parse-server. bin/parse-server is meant to be vanilla and configured only by environment variables.

@gfosco
Copy link
Contributor

gfosco commented Feb 20, 2016

I'd recommend using the parse-server-example repo for your projects, rather than running the bin script here.. https://github.com/parseplatform/parse-server-example

Closing since the UA adapter is available: https://github.com/flovilmart/parse-server-urban-airship

Now, if we only had a nice place to discover parse-server modules...

@gfosco gfosco closed this as completed Feb 20, 2016
@edwardyue
Copy link

Hi thanks!
Sorry I am new to parse.

Could u show me the steps how to make use of parse-server-example with UA
adapter for push notification?

Thanks

Fosco Marotto [email protected] 於 2016年2月21日星期日 寫道:

Closed #404 #404.


Reply to this email directly or view it on GitHub
#404 (comment)
.

Thanks and Regards,
Edward Chan Woon Yue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants