Repository navigation
Using Imagemagick in Cloud Code #648
Description
Hi,
This is not really an issue with Parse-Server, rather a cry for help with using Imagemagick instead of Parse-Image in my cloud code functions. Can anyone point me in the right direction to achieve the same as expressed in my old cloud code:
Parse.Cloud.beforeSave("TheClass", function(request, response) {
var theObject= request.object;
Parse.Cloud.httpRequest({
url: theObject.get("img").url()
}).then(function(response) {
var image = new Image();
return image.setData(response.buffer);
}).then(function(image) {
var currentWidth = image.width();
var currentHeight = image.height();
var ratio = currentHeight / currentWidth;
if (currentWidth > 640) {
return image.scale({
width: 640,
height: 640 * ratio
});
} else {
return image;
}
}).then(function(image) {
return image.setFormat("JPEG");
}).then(function(image) {
return image.data();
}).then(function(buffer) {
var base64 = buffer.toString("base64");
var cropped = new Parse.File("thumb.jpeg", { base64: base64 });
return cropped.save();
}).then(function(cropped) {
theObject.set("thumb", cropped);
}).then(function(result) {
response.success();
}, function(error) {
response.error(error);
});
});
Any help will be much appreciated!
Activity
christianmarth commentedon Feb 25, 2016
Have a look at
https://github.com/hacksparrow/node-easyimage
or
https://github.com/yourdeveloper/node-imagemagick
oyvindvol commentedon Feb 25, 2016
@christianmarth Thanks! E.g. in the first link example (EasyImage), how would you initialize an image from the response.buffer like I do in line 8 of my pasted code?
flovilmart commentedon Feb 25, 2016
@oyvindvol I wrote a wrapper for Parse.Image that has 100% compatibility with the original parse-image:
https://github.com/flovilmart/parse-image.
nitrag commentedon Feb 25, 2016
I was just getting to the point where I needed this too. Thanks @flovilmart !
flovilmart commentedon Feb 25, 2016
@nitrag @oyvindvol the installation is automated on debian and OSX. Installation in Windows is not working yet. For heroku, you need to add a build pack (as explained in the README)
oyvindvol commentedon Feb 25, 2016
@flovilmart Nice! So, to use this on a heroku based install of parse-server, i just add imagemagick , graphicsmagick and your parse-image to my package.json, and add
var Image = require("parse-image")to the top of my cloud code file?flovilmart commentedon Feb 25, 2016
@oyvindvol follow the instructions here: https://github.com/flovilmart/parse-image#heroku-installation
then:
Given the code you provided, it seems that it should work right away.
oyvindvol commentedon Feb 25, 2016
@flovilmart Ok, so now I did only the "Heroku installation" part, and after deploy the heroku logs say "Cannot find module 'parse-image'". Then I added 'parse-image' as a dependency in package.json, and I still get "cannot find module 'parse-image'" in the logs.
flovilmart commentedon Feb 25, 2016
Did you run
npm install --save parse-image?oyvindvol commentedon Feb 25, 2016
@flovilmart On Heroku server?
flovilmart commentedon Feb 25, 2016
does it work locally with foreman?
oyvindvol commentedon Feb 25, 2016
I haven`t tested locally, I am just trying to set it up on my parse-server-example that I deployed directly to Heroku. I configured the heroku-buildpack-graphicsmagick via git bash, and push to heroku master. I can see that the buildpack is installed, but am I also supposed to put something in my package.json for it to work in my cloud code?
flovilmart commentedon Feb 25, 2016
the build pack is installing the binaries required to parse-image to work correctly.
When you push to heroku, you you see parse-image being installed? Can you give me the heroku logs?
oyvindvol commentedon Feb 25, 2016
Ok, starting from fresh. I added the buildpack in git bash. I remove everything regarding parse-image from my package.json, then i do
git push heroku master. This shows in the console:After deploy finished, this is the heroku logs:
flovilmart commentedon Feb 25, 2016
it seems that your package.json is not properly updated, or that heroku don't like it..
Try to run on your machine:
npm install --save parse-imageand then deploy to heroku8 remaining items
oyvindvol commentedon Feb 25, 2016
Well, initially this issue was about using the recommended Imagemagick in parse server cloud code. I am still interested in examples on that though..
flovilmart commentedon Feb 25, 2016
OK, can you post an issue on parse-image I'll re-open in that case.
flovilmart commentedon Feb 25, 2016
http://stackoverflow.com/questions/30309633/after-replacing-rmagick-with-minimagick-gets-identify-im6-no-decode-delegate
simonbengtsson commentedon Feb 25, 2016
I used jimp to replace
parse-imagewhen I migrated our app. It is written entirely in JavaScript for Node so no external dependencies needed (no special install on heroku or windows). It probably has worse performance than imagemagick, but I have yet to run any benchmarks. We are scaling a lot of images in our app however and so far it looks promising.oyvindvol commentedon Feb 26, 2016
@simonbengtsson That looks lightweight and good. Are you using jimp to e.g. save thumbnails via cloud code? I am having trouble getting that work. With the code provided below, everything seems OK, and the thumb is saved on the "Message" object, but viewing the thumb in the browser with the file URL is not working.
simonbengtsson commentedon Feb 26, 2016
Yes we are generating thumbnails in cloud code using jimp. Your issue is probably that the string from
image.hash()cannot be used as data for parse files. Try something like this instead:oyvindvol commentedon Feb 29, 2016
@simonbengtsson Thanks! :) That worked..
nitrag commentedon Mar 3, 2016
Since it took me several hours to get this correct I'm posting here so the next guy has an easier time:
6thfdwp commentedon May 14, 2016
Thanks for sharing this pure js image module, here is the benchmarks I found for jimp in comparison with other libraries.
lovell/sharp#275 (comment)
It seems enough for common image processing cases.
majidhassan commentedon May 29, 2016
@flovilmart I tried your parse-image module on Heroku for a simple thumbnail generation. I did not need to change a single line of code, only added "parse-image": "~0.1.1" in my package.json dependencies, and it works fine so far.
Great job!
rickkrauland commentedon Aug 7, 2016
@nitrag Thanks for your post. Fwiw, I had to add a buffer.toString conversion before I could get everything to work.
parkej60 commentedon Sep 23, 2016
This all seems to be working great for me using jimp until the part where I try to set it to the object in the beforeSave hook. I see the images showing up in S3 and it comes back correctly. I have other attributes that are getting set correctly as well. It is just the 'pictureThumbnail' that isn't. For some reason it just seems as if it's not updating the request.object. @rickkrauland Was there something you had to do different then what is documented in @nitrag 's example?
parkej60 commentedon Sep 23, 2016
So... turns out that response.success doesn't want a string sent along with it. I removed "thumbnail saved" from response.success() and it worked.