Push Status ID and Hash fix

[mihai-iorga]

pushStatusHandler should encode only data.alert to create MD5 Hash

• https://github.com/ParsePlatform/Parse-SDK-iOS-OSX/blob/master/Parse/Internal/Analytics/Utilities/PFAnalyticsUtilities.h

PushController should also send pushStatus.objectId to adapter: adapter can map sends with ids

[codecov-io]

Current coverage is 91.93%

Merging #2067 into master will increase coverage by <.01%

@@             master      #2067   diff @@
==========================================
  Files            93         93          
  Lines          6537       6538     +1   
  Methods        1169       1169          
  Messages          0          0          
  Branches       1370       1371     +1   
==========================================
+ Hits           6010       6011     +1   
  Misses          527        527          
  Partials          0          0          

Powered by Codecov. Last updated by 39f11a5...2017913

[flovilmart]

thanks for the PR!
Just to check, why change the hash to just the alert? I may break analytics on parse.com as I understand. I'll let Nikita check on that.

[mihai-iorga]

Because push_hash generated from app does not match pushHash generated by pushStatusHandler. I see no other logic assuming they both generate a correlation string between _PushStatus and AppOpened event.

[flovilmart]

@nlutsenko the code look good to me. can you confirm the push_hash is computed that way? given the spec here, the full payload should be hashed: https://gist.github.com/flovilmart/bf64276507d685ae41f6#file-_pushstatus-L44

[nlutsenko]

Will double check and get back to you guys tomorrow.
Off the top of my head - yes, this is correct, but Android can have a different payload structure by default.

Also, I would love to kill push hash completely and replace with push id, so we can get deterministic analytics.

[flovilmart]

I'd move for that too, killing the hash, that will require update in the client SDK's which is not that bad.
Also we don't collect analytics on that project, so that won't affect much anyone running parse-server only

[mihai-iorga]

@nlutsenko iOS just hashes that payload.alert and posts to /AppOpened, Android receives the hash from payload.push_hash and posts to /AppOpened, so it's legit. You can calculate that md5 and everything works well. You can correlate in db.

So I do not see any problems.