Skip to content

Change pushHash with stringified data #2397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flovilmart merged 4 commits into from
Aug 9, 2016
Merged

Change pushHash with stringified data #2397

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dd6a62c
Change pushHash with stringify data
alenoir Jul 26, 2016
18d5e05
stringify data.alert for pushHash
alenoir Jul 27, 2016
e40e5eb
stringify data.alert if object for pushHash
alenoir Aug 9, 2016
7ca6190
test push notification when data.alert is an object
alenoir Aug 9, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pushStatusHandler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export default function pushStatusHandler(config) {
expiry: body.expiration_time,
status: "pending",
numSent: 0,
pushHash: md5Hash(data.alert || ''),
pushHash: md5Hash(JSON.stringify(data.alert) || ''),
Copy link
Contributor

@flovilmart flovilmart Aug 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the case alert is a string, that will wrap the string into another string, including the quotes...
This should be updated to:

let pushHash;
if (typeof data.alert === 'string') {
  pushHash = md5Hash(data.alert);
} else if (typeof data.alert === 'object') {
  pushHash = md5Hash(JSON.stringify(data.alert));
} else {
   pushHash = "d41d8cd98f00b204e9800998ecf8427e"; // empty string hash
}

// lockdown!
ACL: {}
}
Expand Down