Don't add transport when folder is /dev/null. Fix bug with options #2476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Current coverage is 91.88% (diff: 100%)@@ master #2476 diff @@
==========================================
Files 95 95
Lines 10706 10708 +2
Methods 1312 1312
Messages 0 0
Branches 1738 1739 +1
==========================================
+ Hits 9837 9839 +2
Misses 869 869
Partials 0 0
|
|
Superceded by #2478 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to use /dev/null as a log folder results in the following error:
This will prevent that. There is also a misplaced options argument on line 34 of the original file