Skip to content

Revert #2705 #2833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2016
Merged

Revert #2705 #2833

merged 1 commit into from
Oct 19, 2016

Conversation

yuki-takeichi
Copy link
Contributor

We should not use legacy filename format when uploading files by parse-server.

The change in filename format by #2705 causes a bug.
Because the filename prefixed by require('node-uuid').v4() passes the test here:
https://github.com/ParsePlatform/parse-server/pull/2001/files#diff-a5627093ba7dcdc8b5392f04905d1cafR69.
As a result all urls that point to user-owned storage are overwritten to a non-exist url that starts with http://files.parse.com/.

I know that reverting #2705 causes another problem. But it's less critical than this bug.

@yuki-takeichi
Copy link
Contributor Author

yuki-takeichi commented Oct 7, 2016

I suggest that filename is prefixed by pssv- for example, and we should fix this code:
https://github.com/ParsePlatform/parse-dashboard/blob/57ca0e003364e16116a92bb4b6ee57a25fecf457/src/lib/getFileName.js#L15.

@flovilmart
Copy link
Contributor

@yuki-takeichi that seems like a great idea, can you do that in the PR instead of the direct reverting?

@yuki-takeichi
Copy link
Contributor Author

@flovilmart OK! I'll do that.

@flovilmart
Copy link
Contributor

@yuki-takeichi any progress on that one?

@flovilmart flovilmart merged commit 758975c into parse-community:master Oct 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants