Implemented a Provider structure for Files, Cache, and Database adapters. Added a new memory cache implementation. #291
Conversation
|
@maysale01 updated the pull request. |
3 similar comments
|
@maysale01 updated the pull request. |
|
@maysale01 updated the pull request. |
|
@maysale01 updated the pull request. |
gnz00
force-pushed
the
new-memory-cache
branch
from
ffeeb4f to
9c4e7ed
Compare
gnz00
changed the title
|
@maysale01 updated the pull request. |
4 similar comments
|
@maysale01 updated the pull request. |
|
@maysale01 updated the pull request. |
|
@maysale01 updated the pull request. |
|
@maysale01 updated the pull request. |
| adapter = require(adapter); | ||
|
|
||
| // TODO: Figure out a better way to deal with this | ||
| if (adapter && adapter.default) |
There was a problem hiding this comment.
What do you wanna do here with the default?
Because either default is a function, so it should be the adapter itself, or it's an object and will skip instantiation and options. Question is why specify .default on an adapter as it's guaranteed to be used?
Signed-off-by: Alexander Mays <[email protected]>
…ests passing. Signed-off-by: Alexander Mays <[email protected]>
Signed-off-by: Alexander Mays <[email protected]>
…ce the singleton pattern. The correct way is to not use the constructor but rather a 'setup', 'init' or other method. Signed-off-by: Alexander Mays <[email protected]>
Signed-off-by: Alexander Mays <[email protected]>
Signed-off-by: Alexander Mays <[email protected]>
…implementation of the said providers and added a ParseApp class. Needs to be documented. Signed-off-by: Alexander Mays <[email protected]>
Signed-off-by: Alexander Mays <[email protected]>
Signed-off-by: Alexander Mays <[email protected]>
Signed-off-by: Alexander Mays <[email protected]>
Signed-off-by: Alexander Mays <[email protected]>
Signed-off-by: Alexander Mays <[email protected]>
…ptions } ... } Signed-off-by: Alexander Mays <[email protected]>
Signed-off-by: Alexander Mays <[email protected]>
gnz00
force-pushed
the
new-memory-cache
branch
from
ed1ca11 to
309775d
Compare
|
@maysale01 updated the pull request. |
|
Trying to do some cleanup here.. I'm going to close this. If you'd like to rebase and squash this down, you can reopen and we'll get it reviewed internally. There is a lot going on here, with 27 files changed, it would be nice if this could be broken up for easier review and understanding. |
No description provided.