Skip to content

Installation push tracking #2994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from

Conversation

alexblack
Copy link

@alexblack alexblack commented Nov 3, 2016

Records push status per Installation, in a new class Push with fields:

  • installation
  • pushStatus
  • result
  • deviceToken

Logic:

  1. A new Push object is created for each (Installation, PushStatusId) when sending pushes to the push adapter
  2. After the push adapter returns, each of those objects is updated with a result

Result scenarios for each push:

  1. No deviceToken found on installation
  2. No result from adapter for installation
  3. Result from adapter

@alexblack
Copy link
Author

npm run test passed locally, but looks like there is an issue causing a test to fail. I'll look at fixing that up.

@flovilmart
Copy link
Contributor

flovilmart commented Nov 3, 2016

Seems that your feature break compatibly with the postgres adapter...

@alexblack
Copy link
Author

Yes :( Is there a way for me to test that out locally? It seems that npm run test didn't catch the problem for me.

@facebook-github-bot
Copy link

@alexblack updated the pull request - view changes

@flovilmart
Copy link
Contributor

We're undergoing a major refactor of the push architecture with #3080.

Closing for now, as the refactor will completely break with that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants