Handles hooks load error #3244
Closed
Handles hooks load error #3244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Feel free to revise my English in source code. I'm not native English speaker. |
flovilmart
suggested changes
Dec 20, 2016
| @@ -243,7 +243,6 @@ class ParseServer { | |||
| Config.validate(AppCache.get(appId)); | |||
| this.config = AppCache.get(appId); | |||
| Config.setupPasswordValidator(this.config.passwordPolicy); | |||
| hooksController.load(); | |||
There was a problem hiding this comment.
And you validation logic should throw if there's an error loading the hooks, inside the hooks controller.
| const server = app.listen(options.port, options.host, callback); | ||
| server.on('connection', initializeConnections); | ||
| const hooksController = AppCache.get(options.appId)['hooksController']; | ||
| hooksController.load().then(() => { |
There was a problem hiding this comment.
No modifications in that file please. Some people don't use the CLIz
|
@yuki-takeichi do you have any updates for this pull request? It's been a while since the last update so wanted to check in and see if you've looked at the requested changes. |
|
@yuki-takeichi I'll be closing this one now, feel free to reopen when the addressing the conflicts and requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the behavior when Parse Server fails to load
_Hookscollection to prevent it from launching with incomplete state. If Parse Server fails to load_Hooksentries, currently it ignores error and launches without setting hooks. This behavior causes serious problems. (For example an important validation logic doesn't work in Before Save Hook.) So my change forces Parse Server to shutdown before it accepts requests.