LiveQuery should match subobjects with dot notation #3322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
@dstarke updated the pull request - view changes |
|
It's unclear why the build failed, but it does not appear to be because of the code in this pull request. The only difference between this check and the previous commit (which passed) was a small addition to a test case which still passes. |
acinader
approved these changes
Jan 7, 2017
| @@ -133,6 +133,13 @@ function matchesKeyConstraints(object, key, constraints) { | |||
| if (constraints === null) { | |||
| return false; | |||
| } | |||
| if(key.indexOf(".") >= 0){ | |||
There was a problem hiding this comment.
No, it isn't, but I didn't see anywhere that invalid keys should be screened out. In this case, it will recursively call matchesKeyConstraints with an empty object, which should result in the same result as what this code was doing before with an invalid key. You could make the comparison > instead of >=, if you think that makes it more clear, but it should ultimately return the same answer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #3321