Fix LiveQuery unsafe user #3525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That looks great! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LiveQuery server was explicitly calling
enableUnsafeCurrentUser(), which should not be used in a server environment.As far as I can tell, this was only used to provide a convenient way to get the user for a session token. I've replaced that mechanism with one that is safe to use when
unsafeCurrentUseris disabled. I've also reviewed the LiveQuery code and fixed a place where it was issuing a call without using the master key.The combination of these issues could result in unexpected failures for invalid session tokens.
Fixes #3516