missing return in test. #3645
Merged
missing return in test. #3645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd also note that the query in this test (for me at least) never actually returns any results. the same query is used in 'should support full RESTQuery for increment', and it too never returns any results. is something broken with RestQuery? |
|
It never returns as the DB is empty, the test only test that it doesn't throw. |
|
sure - but without the return, it doesn't fail even when PushQueue throws. |
|
re the query - what I meant was that the query itself seems bogus as I don't think it could ever return any results even if there were data. |
|
Given the blame info, this was added about a year ago, (b89619b) when the Increment was failing when providing a REST query. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.