Skip to content

Adds graceful shutdown handler for mongodb #3706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2017

Conversation

flovilmart
Copy link
Contributor

When running some performance tests, I realized the server was not shutting down since the removal of process.exit(0) when using the CLI.

This will close gracefully the mongodb connections in order to let the process exit properly.

@flovilmart flovilmart requested a review from acinader April 11, 2017 13:29
@codecov
Copy link

codecov bot commented Apr 11, 2017

Codecov Report

Merging #3706 into master will decrease coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3706      +/-   ##
==========================================
- Coverage   90.39%   90.38%   -0.02%     
==========================================
  Files         114      114              
  Lines        7406     7412       +6     
==========================================
+ Hits         6695     6699       +4     
- Misses        711      713       +2
Impacted Files Coverage Δ
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 93.6% <50%> (-1.58%) ⬇️
src/RestWrite.js 94.3% <0%> (-0.21%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 95.44% <0%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 906fb27...0b1d6fe. Read the comment docs.

@acinader
Copy link
Contributor

@flovilmart coverage not happy.

@flovilmart
Copy link
Contributor Author

AH yeah because I replaced 2 lines by 4... screw that :)

@flovilmart
Copy link
Contributor Author

I can add a test with a subprocess :)

@acinader
Copy link
Contributor

or mark it to ignore for coverage?

@flovilmart
Copy link
Contributor Author

I mean we can merge, that's not a big deal :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants