Fix : User Roles not added to create, update or delete calls #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flessard
changed the title
|
Thanks for attempting to fix this issue. There are 7 test failures to address before further review. |
|
@flessard updated the pull request. |
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
|
Down to 4... You can run tests locally with |
|
@flessard updated the pull request. |
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
| @@ -49,7 +49,7 @@ describe('Parse Role testing', () => { | |||
| }).then((x) => { | |||
| x.set('foo', 'baz'); | |||
| // This should fail: | |||
| return x.save(); | |||
| return x.save({},{sessionToken: ""}); | |||
There was a problem hiding this comment.
I change this because, by default the sessionToken is passed. The result of this never fail.
| @@ -80,7 +80,7 @@ Auth.prototype.getUserRoles = function() { | |||
| return Promise.resolve(this.userRoles); | |||
| } | |||
| if (this.rolePromise) { | |||
| return rolePromise; | |||
| return this.rolePromise; | |||
|
@flessard updated the pull request. |
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
|
@flessard updated the pull request. |
|
@gfosco What is missing on this PR to be merge? |
|
@flessard updated the pull request. |
|
@flessard updated the pull request. |
|
@flessard updated the pull request. |
gfosco
added a commit
that referenced
this pull request
Feb 19, 2016
Fix : User Roles not added to create, update or delete calls
|
👍 |
This was referenced Feb 20, 2016
This was referenced Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.