Skip authData validation if it hasn't changed. #3783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In case of short-lived tokens (like facebook) this will allow clients to be lax with asking users to re-login
acinader
approved these changes
May 7, 2017
Codecov Report
@@ Coverage Diff @@
## master #3783 +/- ##
=======================================
Coverage 90.26% 90.26%
=======================================
Files 114 114
Lines 7491 7491
=======================================
Hits 6762 6762
Misses 729 729
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1455
This will allow expired token to let the user login as well as preventing unnecessary re-validation when editing objects from the dashboard or by other mean that would otherwise fail with a stale token.