Skip to content

Fixes postgres flaky test #3822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions spec/PostgresInitOptions.spec.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const Parse = require('parse/node').Parse;
const PostgresStorageAdapter = require('../src/Adapters/Storage/Postgres/PostgresStorageAdapter');
const postgresURI = 'postgres://localhost:5432/parse_server_postgres_adapter_test_database';

const Config = require('../src/Config');
//public schema
const databaseOptions1 = {
initOptions: {
Expand All @@ -28,33 +28,40 @@ const GameScore = Parse.Object.extend({
className: "GameScore"
});

describe('Postgres database init options', () => {
describe_only_db('postgres')('Postgres database init options', () => {
it('should create server with public schema databaseOptions', (done) => {
const config = new Config('test');
// Close the current DB before continueing
config.database.adapter._pgp.end();
reconfigureServer({
databaseAdapter: new PostgresStorageAdapter({
uri: postgresURI, collectionPrefix: 'test_',
databaseOptions: databaseOptions1
})
}).then(done, fail);
}).then(done, done.fail);
});

it("save new GameScore in public schema", function (done) {
var score = new GameScore({ "score": 1337, "playerName": "Sean Plott", "cheatMode": false });
score.save().then(done, fail);
score.save().then(done, done.fail);
});

it('should fail to create server if schema databaseOptions does not exist', (done) => {
const config = new Config('test');
// Close the current DB before continueing
config.database.adapter._pgp.end();
reconfigureServer({
databaseAdapter: new PostgresStorageAdapter({
uri: postgresURI, collectionPrefix: 'test_',
databaseOptions: databaseOptions2
})
}).then(() => {
done.fail('Should not succeed');
}, error => {
// INVALID_SCHEMA error 3F000
// https://www.postgresql.org/docs/9.5/static/errcodes-appendix.html
expect(error.code).toEqual('3F000');
done();
})
.catch(error => {
expect(error.code).toEqual('42P01');
done();
});
});
});
});
2 changes: 1 addition & 1 deletion src/Adapters/Storage/Postgres/PostgresClient.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,5 @@ export function createClient(uri, databaseOptions) {
}
}

return client;
return { client, pgp };
}
5 changes: 4 additions & 1 deletion src/Adapters/Storage/Postgres/PostgresStorageAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -403,14 +403,17 @@ export class PostgresStorageAdapter {
// Private
_collectionPrefix: string;
_client;
_pgp;

constructor({
uri,
collectionPrefix = '',
databaseOptions
}) {
this._collectionPrefix = collectionPrefix;
this._client = createClient(uri, databaseOptions);
const { client, pgp } = createClient(uri, databaseOptions);
this._client = client;
this._pgp = pgp;
}

_ensureSchemaCollectionExists(conn) {
Expand Down