-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Postgres doesn't support this query type yet #3875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Seems that you have a conflict |
Oops |
Quick question why do Postgres Tests run so fast? Is Postgres better than Mongodb? |
I couldn't say for sure, without proper profiling but:
And I'll take time to profile it correctly as some perf improvements can be easily identified |
Thanks good to know |
I just ran a bunch of profiling of the tests, and nothing stands out as being the culprit for slower / slow tests in the JS code |
I'm just surprised that it takes ~13 minutes to test against mongo. |
not 13 minutes, just over 7 minutes and 5:30 for PG. |
Travis looks ok. I'm asking because when I run locally the time difference is huge. PG - 4 minutes 33 seconds It maybe something with my computer. I'll look into it. What do you use for profile tests? |
For the profiling, I just added --prof to the jasmine runner |
Perhaps because it has to download mongodb through mongodb runner |
Codecov Report
@@ Coverage Diff @@
## master #3875 +/- ##
==========================================
- Coverage 90.26% 90.26% -0.01%
==========================================
Files 114 114
Lines 7574 7578 +4
==========================================
+ Hits 6837 6840 +3
- Misses 737 738 +1
Continue to review full report at Codecov.
|
I found an interesting issue using equalTo on a geoPoint.
This PR fixes this issue.